Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v3]

2024-02-11 Thread Ambarish Rapte
On Wed, 7 Feb 2024 21:41:10 GMT, Andy Goryachev wrote: >> Requesting content layout when font changes. >> >> This change makes the visual impact of >> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so >> perhaps both bugs should be fixed at the same time. > > Andy Gor

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v3]

2024-02-08 Thread Karthik P K
On Wed, 7 Feb 2024 21:41:10 GMT, Andy Goryachev wrote: >> Requesting content layout when font changes. >> >> This change makes the visual impact of >> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so >> perhaps both bugs should be fixed at the same time. > > Andy Gor

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font

2024-02-08 Thread Andy Goryachev
On Wed, 7 Feb 2024 00:08:41 GMT, Kevin Rushforth wrote: > would it be possible to create an automated test for this? created a robot test. - PR Comment: https://git.openjdk.org/jfx/pull/1217#issuecomment-1934700117

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v3]

2024-02-08 Thread Andy Goryachev
On Thu, 8 Feb 2024 10:16:51 GMT, Karthik P K wrote: > the position of text in the TextArea shifts. yes, that's [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) the padding size is expressed in ems which is incorrect - it should be fixed like everywhere else. - PR Comment

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v3]

2024-02-08 Thread Karthik P K
On Wed, 7 Feb 2024 21:41:10 GMT, Andy Goryachev wrote: >> Requesting content layout when font changes. >> >> This change makes the visual impact of >> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so >> perhaps both bugs should be fixed at the same time. > > Andy Gor

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v3]

2024-02-07 Thread Andy Goryachev
> Requesting content layout when font changes. > > This change makes the visual impact of > [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so > perhaps both bugs should be fixed at the same time. Andy Goryachev has updated the pull request incrementally with one additi

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v2]

2024-02-07 Thread Andy Goryachev
> Requesting content layout when font changes. > > This change makes the visual impact of > [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so > perhaps both bugs should be fixed at the same time. Andy Goryachev has updated the pull request incrementally with two additi

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font

2024-02-07 Thread Andy Goryachev
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote: > Requesting content layout when font changes. > > This change makes the visual impact of > [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so > perhaps both bugs should be fixed at the same time. The flicker you

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font

2024-02-07 Thread Karthik P K
On Wed, 7 Feb 2024 10:23:20 GMT, Ambarish Rapte wrote: >> Requesting content layout when font changes. >> >> This change makes the visual impact of >> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so >> perhaps both bugs should be fixed at the same time. > > With thi

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font

2024-02-07 Thread Ambarish Rapte
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote: > Requesting content layout when font changes. > > This change makes the visual impact of > [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so > perhaps both bugs should be fixed at the same time. With this chang

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font

2024-02-07 Thread Ambarish Rapte
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote: > Requesting content layout when font changes. > > This change makes the visual impact of > [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so > perhaps both bugs should be fixed at the same time. modules/javafx.

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font

2024-02-06 Thread Kevin Rushforth
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote: > Requesting content layout when font changes. > > This change makes the visual impact of > [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so > perhaps both bugs should be fixed at the same time. Reviewers: @ara

RFR: 8307117: TextArea: wrapText property ignored when changing font

2024-02-06 Thread Andy Goryachev
Requesting content layout when font changes. This change makes the visual impact of [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so perhaps both bugs should be fixed at the same time. - Commit messages: - Merge branch 'master' into 8307117.wrap - reque

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font

2024-02-06 Thread Andy Goryachev
On Mon, 21 Aug 2023 21:44:12 GMT, Andy Goryachev wrote: > Requesting content layout when font changes. > > This change makes the visual impact of > [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so > perhaps both bugs should be fixed at the same time. keep alive kee