Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-15 Thread Ambarish Rapte
On Thu, 15 Feb 2024 21:59:18 GMT, Alexander Zuev wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review corrections-1 > > modules/javafx.controls/src/main/java/javafx/scene/control/ListCell.java line > 31: >

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-15 Thread Ambarish Rapte
On Thu, 15 Feb 2024 09:57:17 GMT, Marius Hanl wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review corrections-1 > > modules/javafx.controls/src/main/java/javafx/scene/control/ListCell.java line > 376: > >>

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-15 Thread Alexander Zuev
On Wed, 14 Feb 2024 02:55:15 GMT, Ambarish Rapte wrote: >> This is accessibility specific fix. >> >> **Issue**: When a ListView is shown for first time then accessibility focus >> rectangle is not drawn around the focused ListIem >> >> **Cause:** >>The ListView takes a little time to

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-15 Thread Marius Hanl
On Wed, 14 Feb 2024 02:55:15 GMT, Ambarish Rapte wrote: >> This is accessibility specific fix. >> >> **Issue**: When a ListView is shown for first time then accessibility focus >> rectangle is not drawn around the focused ListIem >> >> **Cause:** >>The ListView takes a little time to

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-14 Thread Kevin Rushforth
On Wed, 14 Feb 2024 02:55:15 GMT, Ambarish Rapte wrote: >> This is accessibility specific fix. >> >> **Issue**: When a ListView is shown for first time then accessibility focus >> rectangle is not drawn around the focused ListIem >> >> **Cause:** >>The ListView takes a little time to

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-13 Thread Ambarish Rapte
On Tue, 13 Feb 2024 21:15:16 GMT, Kevin Rushforth wrote: > The fix looks good to me, and my initial testing shows that it works as > expected. I left a few suggestions on minor wording changes inline. I'll > reapprove if you make the changes. Thank you Kevin, Please have a re-look, I made the

Re: RFR: 8309374: Accessibility Focus Rectangle on ListItem is not drawn when ListView is shown for first time [v2]

2024-02-13 Thread Ambarish Rapte
> This is accessibility specific fix. > > **Issue**: When a ListView is shown for first time then accessibility focus > rectangle is not drawn around the focused ListIem > > **Cause:** >The ListView takes a little time to create it's skin(ListViewSkin) and the > skins for