Re: RFR: 8313650: Add hasProperties method to MenuItem and Toggle [v3]

2023-08-22 Thread Andy Goryachev
On Tue, 22 Aug 2023 06:03:01 GMT, John Hendrikx wrote: >> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commi

Re: RFR: 8313650: Add hasProperties method to MenuItem and Toggle [v3]

2023-08-21 Thread John Hendrikx
On Mon, 21 Aug 2023 15:56:59 GMT, Andy Goryachev wrote: >> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares >> two methods: >> - public ObservableMap getProperties(); >> - public boolean hasProperties(); >> >> 2. Node, MenuItem, and Toggle now extend ContainsPropertie

Re: RFR: 8313650: Add hasProperties method to MenuItem and Toggle [v3]

2023-08-21 Thread Andy Goryachev
> 1. Creating a new `javafx.scene.ContainsProperties` interface that declares > two methods: > - public ObservableMap getProperties(); > - public boolean hasProperties(); > > 2. Node, MenuItem, and Toggle now extend ContainsProperties interface. > > 3. Making implemented methods in Node, MenuIte