Re: RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8 [v2]

2023-10-10 Thread Kevin Rushforth
On Mon, 9 Oct 2023 21:06:36 GMT, Ambarish Rapte wrote: >> This is gradle only change, which fixes few warnings that are observed with >> gradle 7.6 and which eventually result to an error with gradle 8.3 >> With this change the warnings get fixed and no error is observed with gradle >> 8.3 >> V

Re: RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8 [v2]

2023-10-10 Thread Johan Vos
On Mon, 9 Oct 2023 21:06:36 GMT, Ambarish Rapte wrote: >> This is gradle only change, which fixes few warnings that are observed with >> gradle 7.6 and which eventually result to an error with gradle 8.3 >> With this change the warnings get fixed and no error is observed with gradle >> 8.3 >> V

Re: RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8

2023-10-09 Thread Ambarish Rapte
On Mon, 9 Oct 2023 17:17:03 GMT, Kevin Rushforth wrote: > Looks like there some GHA failures which will need to be resolved. Possibly a > missing dependency? Yes, I had used `mustRunAfter` to specify order of execution of tasks but looks like it does not guarantee the order of execution. Chang

Re: RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8 [v2]

2023-10-09 Thread Ambarish Rapte
On Mon, 9 Oct 2023 22:48:18 GMT, Kevin Rushforth wrote: > I can see that you had to add a number of additional dependencies. I guess > these all represent latent dependency bugs in our `build.gradle`? Yes Kevin, Some tasks use output directory of other tasks without declaring dependency: This

Re: RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8 [v2]

2023-10-09 Thread Kevin Rushforth
On Mon, 9 Oct 2023 21:06:36 GMT, Ambarish Rapte wrote: >> This is gradle only change, which fixes few warnings that are observed with >> gradle 7.6 and which eventually result to an error with gradle 8.3 >> With this change the warnings get fixed and no error is observed with gradle >> 8.3 >> V

Re: RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8 [v2]

2023-10-09 Thread Ambarish Rapte
> This is gradle only change, which fixes few warnings that are observed with > gradle 7.6 and which eventually result to an error with gradle 8.3 > With this change the warnings get fixed and no error is observed with gradle > 8.3 > Verified that several gradle tasks(all, sdk, javadoc, apps, shi

Re: RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8

2023-10-09 Thread Kevin Rushforth
On Mon, 9 Oct 2023 14:56:39 GMT, Ambarish Rapte wrote: > This is gradle only change, which fixes few warnings that are observed with > gradle 7.6 and which eventually result to an error with gradle 8.3 > With this change the warnings get fixed and no error is observed with gradle > 8.3 > Verifi

RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8

2023-10-09 Thread Ambarish Rapte
This is gradle only change, which fixes few warnings that are observed with gradle 7.6 and which eventually result to an error with gradle 8.3 With this change the warnings get fixed and no error is observed with gradle 8.3 Verified that several gradle tasks(all, sdk, javadoc, apps, shims, test)

Re: RFR: 8314486: JavaFX build uses deprecated features that will be removed in gradle 8

2023-10-09 Thread Ambarish Rapte
On Mon, 9 Oct 2023 14:56:39 GMT, Ambarish Rapte wrote: > This is gradle only change, which fixes few warnings that are observed with > gradle 7.6 and which eventually result to an error with gradle 8.3 > With this change the warnings get fixed and no error is observed with gradle > 8.3 > Verifi