Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v2]

2023-10-26 Thread Prasanta Sadhukhan
On Thu, 26 Oct 2023 18:16:26 GMT, Andy Goryachev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Optimization > > modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 817: > >> 815:

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v2]

2023-10-26 Thread Andy Goryachev
On Thu, 26 Oct 2023 16:27:03 GMT, Prasanta Sadhukhan wrote: >> FX Nodes embedded in a Swing JFXPanel does not track the component >> orientation and FX nodes remain unaffected when component orientation >> changes. >> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v2]

2023-10-26 Thread Andy Goryachev
On Thu, 26 Oct 2023 16:27:03 GMT, Prasanta Sadhukhan wrote: >> FX Nodes embedded in a Swing JFXPanel does not track the component >> orientation and FX nodes remain unaffected when component orientation >> changes. >> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v2]

2023-10-26 Thread Prasanta Sadhukhan
On Thu, 26 Oct 2023 15:31:02 GMT, Andy Goryachev wrote: >> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Optimization > > modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 817: > >> 815:

Re: RFR: 8317836: FX nodes embedded in JFXPanel need to track component orientation [v2]

2023-10-26 Thread Prasanta Sadhukhan
> FX Nodes embedded in a Swing JFXPanel does not track the component > orientation and FX nodes remain unaffected when component orientation changes. > Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value > from the JFXPanel. Prasanta Sadhukhan has updated the pull request