On Mon, 30 Oct 2023 15:23:45 GMT, Kevin Rushforth wrote:
>> Yes, initialization helped..Updated the PR...
>> Also, speaking of regression test, I need some time to create one.. Will it
>> be ok to push the fix if found to be ok and I work on the test
>> simultaneously as a separate JBS test iss
On Mon, 30 Oct 2023 13:54:30 GMT, Prasanta Sadhukhan
wrote:
>> This might be due to the initialization problem I pointed out or it might be
>> for some other reason. Can you make the suggested change and then re-test?
>
> Yes, initialization helped..Updated the PR...
> Also, speaking of regress
On Mon, 30 Oct 2023 12:53:07 GMT, Kevin Rushforth wrote:
>> I have made the suggested changes and updated the PR.
>> But it seems the orientation of the text in the test attached in JBS is at
>> the middle initially (and not at LTR or RTL) and it only begins to track the
>> orientation after 1
On Mon, 30 Oct 2023 07:19:54 GMT, Prasanta Sadhukhan
wrote:
>> Yes, you are right that JFXPanel needs to call into the stage and not the
>> other way around. The general approach now looks correct, however, you'll
>> need to add the orientation attribute on the JavaFX Window
>> (`EmbeddedWind
On Sat, 28 Oct 2023 18:25:53 GMT, Kevin Rushforth wrote:
>> I have tried to put in place what you suggested. Can you please take a look
>> at the PR and see if it's in the right direction and suggest further.
>> I have few doubts
>>
>> - It seems JFXPanel call EmbeddedStage interface methods an
On Sat, 28 Oct 2023 07:15:12 GMT, Prasanta Sadhukhan
wrote:
>> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 822:
>>
>>> 820: scene.setNodeOrientation(rtl ?
>>> 821:
>>> NodeOrientation.RIGHT_TO_LEFT :
On Fri, 27 Oct 2023 16:55:30 GMT, Kevin Rushforth wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code optimize
>
> modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 822:
>
>> 820:
On Fri, 27 Oct 2023 03:19:05 GMT, Prasanta Sadhukhan
wrote:
>> FX Nodes embedded in a Swing JFXPanel does not track the component
>> orientation and FX nodes remain unaffected when component orientation
>> changes.
>> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> FX Nodes embedded in a Swing JFXPanel does not track the component
> orientation and FX nodes remain unaffected when component orientation changes.
> Fix made sure JavaFX scene embedded in a JFXPanel should inherit the value
> from the JFXPanel.
Prasanta Sadhukhan has updated the pull request
