On Mon, 6 Nov 2023 06:06:35 GMT, Prasanta Sadhukhan
wrote:
>> A manual regression test for JFXPanel orientation fix in
>> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since
On Mon, 6 Nov 2023 19:30:28 GMT, Kevin Rushforth wrote:
> Can you file an enhancement to consider this for the next test sprint?
Created [JDK-8319555](https://bugs.openjdk.org/browse/JDK-8319555)
-
PR Comment: https://git.openjdk.org/jfx/pull/1276#issuecomment-1796178835
On Mon, 6 Nov 2023 18:43:48 GMT, Andy Goryachev wrote:
> I was waiting for changes to set the window position, but can re-approve if
> necessary.
His earlier comments suggested that he felt it wasn't needed for this PR; with
the adjusted window sizes, the windows no longer overlap.
> A side
On Mon, 6 Nov 2023 06:06:35 GMT, Prasanta Sadhukhan
wrote:
>> A manual regression test for JFXPanel orientation fix in
>> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since
On Mon, 6 Nov 2023 06:06:35 GMT, Prasanta Sadhukhan
wrote:
>> A manual regression test for JFXPanel orientation fix in
>> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since
On Mon, 6 Nov 2023 06:06:55 GMT, Prasanta Sadhukhan
wrote:
> Is there any in-house or public fx documentation that I can peruse (guess we
> dont have similar to
> https://docs.oracle.com/en/java/javase/21/docs/api/index.html)
Andy already answered your specific question. As for where the
On Mon, 6 Nov 2023 06:06:55 GMT, Prasanta Sadhukhan
wrote:
> can you please specify how to do it for my future reference as I dont see
> Scene accepting x,y params
Use Stage (Window) setX(), setY() before show().
-
PR Comment:
On Sat, 4 Nov 2023 13:48:48 GMT, Kevin Rushforth wrote:
> make the test window smaller so they don't overlap
Done
> Maybe set the X and Y of the instruction window
Although it is probably not required now, but can you please specify how to do
it for my future reference as I dont see Scene
> A manual regression test for JFXPanel orientation fix in
> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
Prasanta Sadhukhan has updated the pull request incrementally with two
additional commits since the last revision:
- Formatting
- Modify window size
-
On Thu, 2 Nov 2023 06:04:23 GMT, Prasanta Sadhukhan
wrote:
> A manual regression test for JFXPanel orientation fix in
> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
I verified that this test passes with the fix for JDK-8317836 and fails with
that fix locally reverted.
On Thu, 2 Nov 2023 06:04:23 GMT, Prasanta Sadhukhan
wrote:
> A manual regression test for JFXPanel orientation fix in
> [JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
looks good, works as expected with the latest master.
-
Marked as reviewed by angorya
A manual regression test for JFXPanel orientation fix in
[JDK-8317836](https://bugs.openjdk.org/browse/JDK-8317836) is added
-
Commit messages:
- Test fix
- Test fix
Changes: https://git.openjdk.org/jfx/pull/1276/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1276=00
12 matches
Mail list logo
