Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2024-06-13 Thread Johan Vos
On Tue, 12 Dec 2023 07:05:49 GMT, Ambarish Rapte wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewers comments > > Looks all good to me. > Is it possible to add an automated test ? @arapte if possible, c

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2024-06-12 Thread Johan Vos
On Wed, 13 Dec 2023 09:20:12 GMT, Jose Pereda wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewers comments > > About adding an automated test, the leak that PR tries to fix happens in > `com.sun.javafx.

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-12-13 Thread Jose Pereda
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one addition

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-12-13 Thread Jose Pereda
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one addition

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-12-11 Thread Ambarish Rapte
On Mon, 20 Nov 2023 08:00:58 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one addition

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-11-20 Thread Johan Vos
On Fri, 10 Nov 2023 12:37:13 GMT, John Hendrikx wrote: >> Johan Vos has updated the pull request incrementally with one additional >> commit since the last revision: >> >> process reviewers comments > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java > li

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v2]

2023-11-20 Thread Johan Vos
> A listener was added but never removed. > This patch removes the listener when the menu it links to is cleared. Fix for > https://bugs.openjdk.org/browse/JDK-8319779 Johan Vos has updated the pull request incrementally with one additional commit since the last revision: process reviewers co