Re: RFR: 8320912: IME should commit on focus change

2024-04-29 Thread Andy Goryachev
On Mon, 29 Apr 2024 14:09:03 GMT, yosbits wrote: > I found a serious problem with this change. Thank you! I've created https://bugs.openjdk.org/browse/JDK-8331319 feel free to update / clarify the information in the ticket. - PR Comment:

Re: RFR: 8320912: IME should commit on focus change

2024-04-29 Thread yosbits
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote: > This is a Mac only bug. If the user was in the middle of IM text composition > and clicked on a different node the partially composed text was left in the > old node and the IM window wasn't dismissed. This PR implements the existing >

Re: RFR: 8320912: IME should commit on focus change

2024-02-02 Thread Martin Fox
On Fri, 2 Feb 2024 16:11:52 GMT, Kevin Rushforth wrote: >> This is a Mac only bug. If the user was in the middle of IM text composition >> and clicked on a different node the partially composed text was left in the >> old node and the IM window wasn't dismissed. This PR implements the existing

Re: RFR: 8320912: IME should commit on focus change

2024-02-02 Thread Kevin Rushforth
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote: > This is a Mac only bug. If the user was in the middle of IM text composition > and clicked on a different node the partially composed text was left in the > old node and the IM window wasn't dismissed. This PR implements the existing >

Re: RFR: 8320912: IME should commit on focus change

2024-02-01 Thread Andy Goryachev
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote: > This is a Mac only bug. If the user was in the middle of IM text composition > and clicked on a different node the partially composed text was left in the > old node and the IM window wasn't dismissed. This PR implements the existing >

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Martin Fox
On Wed, 31 Jan 2024 21:49:32 GMT, Andy Goryachev wrote: >>>notice how the underline under あ is still there in the first text field. >> >> That behavior surprised me the first time I saw it but I eventually figured >> out that it's a feature, not a bug. If you switch back to the original

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Andy Goryachev
On Wed, 31 Jan 2024 20:55:16 GMT, Martin Fox wrote: > e.g. the IM window should appear showing the same candidates it was showing > earlier. Thank you for clarification! The behavior is different, let me explain: using the MonkeyTester, open TextField page and the Native-to-ascii tool (Tools

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Martin Fox
On Wed, 31 Jan 2024 20:07:05 GMT, Andy Goryachev wrote: > Another problem I see, and it might be a totally separate issue, is that > sometimes when I launch the Monkey Tester and switch to Japanese input, > TextField is still receives US input, despite the IME window appearing. That behavior

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Martin Fox
On Wed, 31 Jan 2024 18:44:55 GMT, Andy Goryachev wrote: >notice how the underline under あ is still there in the first text field. That behavior surprised me the first time I saw it but I eventually figured out that it's a feature, not a bug. If you switch back to the original window by

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Andy Goryachev
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote: > This is a Mac only bug. If the user was in the middle of IM text composition > and clicked on a different node the partially composed text was left in the > old node and the IM window wasn't dismissed. This PR implements the existing >

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Andy Goryachev
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote: > This is a Mac only bug. If the user was in the middle of IM text composition > and clicked on a different node the partially composed text was left in the > old node and the IM window wasn't dismissed. This PR implements the existing >

RFR: 8320912: IME should commit on focus change

2024-01-30 Thread Martin Fox
This is a Mac only bug. If the user was in the middle of IM text composition and clicked on a different node the partially composed text was left in the old node and the IM window wasn't dismissed. This PR implements the existing finishInputMethodComposition call so it can commit the text and