Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-21 Thread Kevin Rushforth
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote: >> Move caret animation handling due to keyboard input to the Skin, by >> registering a listener on the caretPosition property. This will restart >> animation only when the caret position changes instead of every key press. >> >> This al

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-19 Thread Karthik P K
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote: >> Move caret animation handling due to keyboard input to the Skin, by >> registering a listener on the caretPosition property. This will restart >> animation only when the caret position changes instead of every key press. >> >> This al

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread Andy Goryachev
On Fri, 16 Feb 2024 19:23:00 GMT, John Hendrikx wrote: > I think those tests should be unit tests, not via Robot Preferably, yes. If something can be tested via headless unit tests, it should be done so, you are absolutely right. Some tests, however, require a fully rendered skin - for exampl

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread John Hendrikx
On Fri, 16 Feb 2024 16:00:07 GMT, Andy Goryachev wrote: > As a side note, before we can start re-writing the controls' behaviors, we > should: > > a) identify all the behavioral aspects of each control and b) develop a set > of tests to exercise each one, along the lines of > [JDK-8314906](ht

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread Andy Goryachev
On Fri, 16 Feb 2024 13:15:14 GMT, John Hendrikx wrote: > so I guess I'll file another one. Thank you, please do. As a side note, before we can start re-writing the controls' behaviors, we should: a) identify all the behavioral aspects of each control and b) develop a set of tests to exercise

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread Andy Goryachev
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote: >> Move caret animation handling due to keyboard input to the Skin, by >> registering a listener on the caretPosition property. This will restart >> animation only when the caret position changes instead of every key press. >> >> This al

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread John Hendrikx
On Thu, 15 Feb 2024 17:26:39 GMT, Andy Goryachev wrote: > > I think if we're busy here, it would be worthwhile to also remove the other > > calls to the skin to change the caret animating. > > I would rather not: it would require a much larger effort. Avoiding the caret > flickering when its p

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-16 Thread John Hendrikx
On Thu, 15 Feb 2024 17:29:10 GMT, Andy Goryachev wrote: >> Move caret animation handling due to keyboard input to the Skin, by >> registering a listener on the caretPosition property. This will restart >> animation only when the caret position changes instead of every key press. >> >> This al

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-15 Thread Andy Goryachev
On Thu, 15 Feb 2024 14:08:59 GMT, John Hendrikx wrote: > I think if we're busy here, it would be worthwhile to also remove the other > calls to the skin to change the caret animating. I would rather not: it would require a much larger effort. Avoiding the caret flickering when its position do

Re: RFR: 8322748: Caret blinking in JavaFX should only stop when caret moves [v2]

2024-02-15 Thread Andy Goryachev
> Move caret animation handling due to keyboard input to the Skin, by > registering a listener on the caretPosition property. This will restart > animation only when the caret position changes instead of every key press. > > This also simplifies internal behaviors of TextArea, TextField, and >