Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 15:39:32 GMT, Nir Lisker wrote: >> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronisityTest.java >> line 65: >> >>> 63: } >>> 64: >>> 65: waiter.await(GRACE_PERIOD, TimeUnit.SECONDS); >> >> I don't think this will do what you want. This wi

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-29 Thread Nir Lisker
On Mon, 29 Jan 2024 13:07:21 GMT, Kevin Rushforth wrote: > I don't think this will do what you want. This will return almost > immediately, before any of the animation has run (as soon as the runnable > that sets the uncaught exception handler finished). I observed that this setup works correc

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 09:33:35 GMT, Jose Pereda wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update tests > > tests/system/src/test/java/test/com/sun/javafx/animation/SynchronisityTest.java > line 20: > >> 18: >>

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-29 Thread Kevin Rushforth
On Mon, 29 Jan 2024 03:28:51 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-29 Thread Jose Pereda
On Mon, 29 Jan 2024 03:28:51 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v9]

2024-01-28 Thread Nir Lisker
> Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Update tests - Changes: - all: https://git.openjd