Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-04 Thread Marius Hanl
On Wed, 3 Apr 2024 19:54:20 GMT, Jose Pereda wrote: >> This PR fixes the issue that after committing an edit on a >> ListView/TreeView/TableView/TreeTableView control, the control might lose >> the focus unexpectedly. >> >> For that, it refactors the >> `ControlUtils::requestFocusOnControlOnl

Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-04 Thread Marius Hanl
On Wed, 3 Apr 2024 19:51:08 GMT, Jose Pereda wrote: >> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.java >> line 2362: >> >>> 2360: assertTrue(treeView.isFocused()); >>> 2361: >>> 2362: VirtualFlowTestUtils.BLOCK_STAGE_LOADER_DISPOSE = true; >>

Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-03 Thread Andy Goryachev
On Wed, 3 Apr 2024 19:54:20 GMT, Jose Pereda wrote: >> This PR fixes the issue that after committing an edit on a >> ListView/TreeView/TableView/TreeTableView control, the control might lose >> the focus unexpectedly. >> >> For that, it refactors the >> `ControlUtils::requestFocusOnControlOnl

Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-03 Thread Jose Pereda
> This PR fixes the issue that after committing an edit on a > ListView/TreeView/TableView/TreeTableView control, the control might lose the > focus unexpectedly. > > For that, it refactors the > `ControlUtils::requestFocusOnControlOnlyIfCurrentFocusOwnerIsChild` method, > in order to check if

Re: RFR: 8324939: Editable TableView loses focus after commit [v2]

2024-04-03 Thread Jose Pereda
On Thu, 28 Mar 2024 11:20:23 GMT, Marius Hanl wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Address feedback from reviewer > > modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeViewTest.java > l