Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc [v2]

2024-02-23 Thread Kevin Rushforth
On Fri, 23 Feb 2024 22:32:23 GMT, Andy Goryachev wrote: >> `@return` statements usually state this condition explicitly, like >> `Map#get`: "the value to which the specified key is mapped, or `null` if >> this map contains no mapping for the key". > > My point is that it should be mentioned in

Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc [v2]

2024-02-23 Thread Andy Goryachev
On Fri, 23 Feb 2024 22:32:16 GMT, Nir Lisker wrote: >> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs >> in `Node` and `Scene`. >> >> Note that the default value for a `Scene`'s `NodeOrientation` depends on a >> system property, while for `Node` it isn't (which mean

Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc [v2]

2024-02-23 Thread Kevin Rushforth
On Fri, 23 Feb 2024 22:32:16 GMT, Nir Lisker wrote: >> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs >> in `Node` and `Scene`. >> >> Note that the default value for a `Scene`'s `NodeOrientation` depends on a >> system property, while for `Node` it isn't (which mean

Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc [v2]

2024-02-23 Thread Andy Goryachev
On Fri, 23 Feb 2024 21:58:30 GMT, Nir Lisker wrote: >> I don't mind either way. > > `@return` statements usually state this condition explicitly, like `Map#get`: > "the value to which the specified key is mapped, or `null` if this map > contains no mapping for the key". My point is that it sho

Re: RFR: 8325550: Grammatical error in AnchorPane.setLeftAnchor (and other setters) javadoc [v2]

2024-02-23 Thread Nir Lisker
> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in > `Node` and `Scene`. > > Note that the default value for a `Scene`'s `NodeOrientation` depends on a > system property, while for `Node` it isn't (which means `SubScene` will be > different from `Scene`). Not sure i