Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-05-15 Thread Ambarish Rapte
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. LGTM, tested with and without fix, with and

Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-05-15 Thread Ambarish Rapte
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. I could verify that this change fixes the issue

Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-05-06 Thread Christopher Schnick
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. I can confirm on my system that this PR fixes

Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-05-06 Thread Kevin Rushforth
On Sat, 4 May 2024 23:03:25 GMT, Christopher Schnick wrote: > So I can reproduce this on my system now and could potentially test this PR. > How would one go about this, testing a specific PR? You will need to checkout the PR branch and build JavaFX from source. See the "Using git"

Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-05-04 Thread Christopher Schnick
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. So I can reproduce this on my system now and

Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-04-07 Thread Thiago Milczarek Sayao
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. High chance it's the same problem.

Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-04-06 Thread Christopher Schnick
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. I recently got a report from a user running the

RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-04-06 Thread Thiago Milczarek Sayao
Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. It seems i3 replies with decorated sizes, even if window is not decorated. Won't hurt other WMs. - Commit messages: - - Fix for i3 menus size Changes: https://git.openjdk.org/jfx/pull/1437/files Webrev: