Re: RFR: 8332251: javadoc: incorrect reference in Region.getPrefWidth/Height [v2]

2024-05-16 Thread Ambarish Rapte
On Thu, 16 May 2024 14:54:47 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line >> 1212: >> >>> 1210: * >>> 1211: * Defaults to the USE_COMPUTED_SIZE flag, which >>> means that >>> 1212: * {@link #prefHeight(forWidth)} will

Re: RFR: 8332251: javadoc: incorrect reference in Region.getPrefWidth/Height [v2]

2024-05-16 Thread Ambarish Rapte
On Thu, 16 May 2024 14:58:29 GMT, Andy Goryachev wrote: >> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers >> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)` >> >> should be >> >> `prefHeight(forWidth) / prefWidth(forHeight)` >> >> - same issue is also fixe

Re: RFR: 8332251: javadoc: incorrect reference in Region.getPrefWidth/Height [v2]

2024-05-16 Thread Andy Goryachev
> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers > to `getPrefHeight(forWidth) / getPrefWidth(forHeight)` > > should be > > `prefHeight(forWidth) / prefWidth(forHeight)` > > - same issue is also fixed in `PopupControl`. Andy Goryachev has updated the pull request

Re: RFR: 8332251: javadoc: incorrect reference in Region.getPrefWidth/Height [v2]

2024-05-16 Thread Andy Goryachev
On Thu, 16 May 2024 10:01:05 GMT, Ambarish Rapte wrote: >> Andy Goryachev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> popup control > > modules/javafx.graphics/src/main/java/javafx/scene/layout/Region.java line > 1212: > >> 1210:

Re: RFR: 8332251: javadoc: incorrect reference in Region.getPrefWidth/Height

2024-05-16 Thread Ambarish Rapte
On Wed, 15 May 2024 23:01:30 GMT, Andy Goryachev wrote: > The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers > to `getPrefHeight(forWidth) / getPrefWidth(forHeight)` > > should be > > `prefHeight(forWidth) / prefWidth(forHeight)` > > - also converted these references

RFR: 8332251: javadoc: incorrect reference in Region.getPrefWidth/Height

2024-05-15 Thread Andy Goryachev
The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers to `getPrefHeight(forWidth) / getPrefWidth(forHeight)` should be `prefHeight(forWidth) / prefWidth(forHeight)` - also converted these references to `{@link}`s. - Commit messages: - 8332251: javadoc: inco