Re: RFR: 8332748: Grammatical errors in animation API docs [v2]

2024-05-29 Thread Andy Goryachev
On Wed, 29 May 2024 15:52:36 GMT, Lukasz Kostyra wrote: >> Checked code and fixed the gramatical error in Transition files: >> s/interval/intervals >> >> Fill and Stroke Transition had correct grammatical form already, so those >> were untouched. I couldn't find any other instances of this err

Re: RFR: 8332748: Grammatical errors in animation API docs [v2]

2024-05-29 Thread Nir Lisker
On Wed, 29 May 2024 15:52:36 GMT, Lukasz Kostyra wrote: >> Checked code and fixed the gramatical error in Transition files: >> s/interval/intervals >> >> Fill and Stroke Transition had correct grammatical form already, so those >> were untouched. I couldn't find any other instances of this err

Re: RFR: 8332748: Grammatical errors in animation API docs

2024-05-29 Thread Lukasz Kostyra
On Wed, 29 May 2024 14:23:16 GMT, Nir Lisker wrote: > `ScaleTransition` is missing a fix. Newline in the comment between "regular" and "interval" got me... Should be all good now. - PR Comment: https://git.openjdk.org/jfx/pull/1466#issuecomment-2137740568

Re: RFR: 8332748: Grammatical errors in animation API docs [v2]

2024-05-29 Thread Lukasz Kostyra
> Checked code and fixed the gramatical error in Transition files: > s/interval/intervals > > Fill and Stroke Transition had correct grammatical form already, so those > were untouched. I couldn't find any other instances of this error in our > javadoc documentation. Lukasz Kostyra has updated

Re: RFR: 8332748: Grammatical errors in animation API docs

2024-05-29 Thread Nir Lisker
On Wed, 29 May 2024 06:53:40 GMT, Lukasz Kostyra wrote: > Checked code and fixed the gramatical error in Transition files: > s/interval/intervals > > Fill and Stroke Transition had correct grammatical form already, so those > were untouched. I couldn't find any other instances of this error in

RFR: 8332748: Grammatical errors in animation API docs

2024-05-28 Thread Lukasz Kostyra
Checked code and fixed the gramatical error in Transition files: s/interval/intervals Fill and Stroke Transition had correct grammatical form already, so those were untouched. I couldn't find any other instances of this error in our javadoc documentation. - Commit messages: - Fix