Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v5]

2023-03-02 Thread Thiago Milczarek Sayao
On Fri, 3 Mar 2023 01:13:49 GMT, Thiago Milczarek Sayao wrote: >> This PR does: >> >> - Remove specific Idea files and let it be imported from gradle; >> - Adds checkstyle (to use with checkstyle plugin - it will let you know >> style mistakes); >> - Configures auto-format to sun style (with t

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v5]

2023-03-02 Thread Thiago Milczarek Sayao
> This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the changes mentioned in [Code > Style Rules](https://wiki.openjdk.org/d

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v4]

2023-03-02 Thread Thiago Milczarek Sayao
> This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the changes mentioned in [Code > Style Rules](https://wiki.openjdk.org/d

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v3]

2023-02-23 Thread Marius Hanl
On Thu, 23 Feb 2023 00:41:28 GMT, Thiago Milczarek Sayao wrote: >> This PR does: >> >> - Remove specific Idea files and let it be imported from gradle; >> - Adds checkstyle (to use with checkstyle plugin - it will let you know >> style mistakes); >> - Configures auto-format to sun style (with

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v3]

2023-02-22 Thread Thiago Milczarek Sayao
On Wed, 22 Feb 2023 15:24:57 GMT, Marius Hanl wrote: >> Each user probably would have to configure a JDK for the project. > > Yes I agree. But since the minimum supported language level for OpenJFX is > JDK-17 and this file is part of the version control, I would recommend we > synchronize the

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v3]

2023-02-22 Thread Thiago Milczarek Sayao
> This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the changes mentioned in [Code > Style Rules](https://wiki.openjdk.org/d

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v2]

2023-02-22 Thread Marius Hanl
On Sun, 19 Feb 2023 01:22:58 GMT, Thiago Milczarek Sayao wrote: >> .idea/misc.xml line 8: >> >>> 6: >>> 7: >> IDEtalkID="9BC0DE4049720C1246C2D3B835C6F7C3" /> >>> 8: >> languageLevel="JDK_17" project-jdk-name="19" project-jdk-type="JavaSDK"> >> >> I think this should be `project-jdk-name

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v2]

2023-02-18 Thread Thiago Milczarek Sayao
> This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the changes mentioned in [Code > Style Rules](https://wiki.openjdk.org/d

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v2]

2023-02-18 Thread Thiago Milczarek Sayao
On Mon, 13 Feb 2023 17:48:35 GMT, Marius Hanl wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Review changes > > .idea/codeStyles/Project.xml line 2: > >> 1: >> 2: > > Maybe `OpenJFX` is a better na

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository

2023-02-13 Thread Marius Hanl
On Mon, 23 Jan 2023 23:55:51 GMT, Thiago Milczarek Sayao wrote: > This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the ch

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository

2023-01-31 Thread Kevin Rushforth
On Mon, 23 Jan 2023 23:55:51 GMT, Thiago Milczarek Sayao wrote: > This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the ch

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository

2023-01-29 Thread Marius Hanl
On Mon, 23 Jan 2023 23:55:51 GMT, Thiago Milczarek Sayao wrote: > This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the ch

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository

2023-01-29 Thread Andy Goryachev
On Mon, 23 Jan 2023 23:55:51 GMT, Thiago Milczarek Sayao wrote: > This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the ch

Re: RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository

2023-01-29 Thread Thiago Milczarek Sayao
On Mon, 23 Jan 2023 23:55:51 GMT, Thiago Milczarek Sayao wrote: > This PR does: > > - Remove specific Idea files and let it be imported from gradle; > - Adds checkstyle (to use with checkstyle plugin - it will let you know style > mistakes); > - Configures auto-format to sun style (with the ch

RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository

2023-01-29 Thread Thiago Milczarek Sayao
This PR does: - Remove specific Idea files and let it be imported from gradle; - Adds checkstyle (to use with checkstyle plugin - it will let you know style mistakes); - Configures auto-format to sun style (with the changes mentioned in [Code Style Rules](https://wiki.openjdk.org/display/OpenJFX