Re: RFR: JDK-8295236: Update JavaDoc in javafx.geometry.Point3D [v4]

2022-10-19 Thread Nir Lisker
On Wed, 19 Oct 2022 12:33:37 GMT, Douglas Held wrote: > I thought the code tags produced hyperlinks. Those would be the `@link` tags, or `@linkplain`. - PR: https://git.openjdk.org/jfx/pull/913

Re: RFR: JDK-8295236: Update JavaDoc in javafx.geometry.Point3D [v4]

2022-10-19 Thread Douglas Held
On Tue, 18 Oct 2022 22:15:35 GMT, Douglas Held wrote: >> The JavaDoc for equals had a copy/paste error. I normalized the text based >> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting >> in the method signatures of equals(), hashCode() and toString().~~ >> >> For

Re: RFR: JDK-8295236: Update JavaDoc in javafx.geometry.Point3D [v4]

2022-10-18 Thread Nir Lisker
On Tue, 18 Oct 2022 22:15:35 GMT, Douglas Held wrote: >> The JavaDoc for equals had a copy/paste error. I normalized the text based >> on the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting >> in the method signatures of equals(), hashCode() and toString().~~ >> >> For

Re: RFR: JDK-8295236: Update JavaDoc in javafx.geometry.Point3D [v4]

2022-10-18 Thread Douglas Held
On Tue, 18 Oct 2022 11:32:04 GMT, Nir Lisker wrote: >> Agreed, mentioning equality criteria sounds good to me too. How does this >> look ? >> >> >> /** >> * Indicates whether some other object is "equal to" this one. >> * Two instances of Point3D are equal if the return values

Re: RFR: JDK-8295236: Update JavaDoc in javafx.geometry.Point3D [v4]

2022-10-18 Thread Douglas Held
On Thu, 13 Oct 2022 14:16:23 GMT, Nir Lisker wrote: >> Douglas Held has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Point3D.java >> >> Per review > > Changes requested by nlisker (Reviewer). Tagged @nlisker to validate the

Re: RFR: JDK-8295236: Update JavaDoc in javafx.geometry.Point3D [v4]

2022-10-18 Thread Douglas Held
> The JavaDoc for equals had a copy/paste error. I normalized the text based on > the JavaDoc for method java.awt.Point#equals. ~~I also changed formatting in > the method signatures of equals(), hashCode() and toString().~~ > > For good measure, some kind of copy/paste detection should