On Thu, 27 Apr 2023 19:15:56 GMT, John Hendrikx wrote:
>> Region has floor and ceiling functions that ensure that calling them twice
>> in a row will yield the same result:
>>
>> ceil(x) = ceil(ceil(x))
>>
>> However, due to use of a constant `EPSILON` which is added/subtracted before
On Tue, 2 May 2023 15:38:06 GMT, Andy Goryachev wrote:
> > Okay, I will investigate, I have an idea what this can be, just very
> > surprised that the rounding fixes would cause any issues in this code.
>
> Thank you. I wonder if other places might also exhibit a similar failure
> mode.
On Tue, 2 May 2023 15:18:02 GMT, John Hendrikx wrote:
> Okay, I will investigate, I have an idea what this can be, just very
> surprised that the rounding fixes would cause any issues in this code.
Thank you.
I wonder if other places might also exhibit a similar failure mode.
`scaledCeil`
On Tue, 2 May 2023 15:15:00 GMT, Andy Goryachev wrote:
> > I'm not able to reproduce it.
>
> I am trying to run the code after a clean build, and can't - the MonkeyTester
> freezes going in an infinite loop in HBox.growOrShrinkAreaWidths() on line
> 517 when launching to an HBox page.
>
>
On Thu, 27 Apr 2023 19:15:56 GMT, John Hendrikx wrote:
>> Region has floor and ceiling functions that ensure that calling them twice
>> in a row will yield the same result:
>>
>> ceil(x) = ceil(ceil(x))
>>
>> However, due to use of a constant `EPSILON` which is added/subtracted before
On Fri, 28 Apr 2023 12:25:19 GMT, John Hendrikx wrote:
>> Not sure I quite understand what you are asking, so -
>>
>> 1. the test is good, it's a reasonable approach for a situation with a large
>> space. An exhaustive tests using floats that I ran passes, no need (I
>> think) to run it on
On Thu, 27 Apr 2023 19:43:14 GMT, Andy Goryachev wrote:
>> What are we trying to achieve here I'm wondering? Because if it is to slowly
>> exhaustively test more and more of the problem space during each build, then
>> I really disagree with the methodology.
>>
>> We're confident that this is
On Thu, 27 Apr 2023 19:04:39 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Thu, 27 Apr 2023 19:32:02 GMT, John Hendrikx wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/scene/layout/RegionTest.java
>> line 1281:
>>
>>> 1279: }
>>> 1280:
>>> 1281: random.setSeed(seed);
>>
>> it might be better to set the seed only once at the beginning.
On Thu, 27 Apr 2023 15:27:14 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Thu, 27 Apr 2023 19:04:39 GMT, John Hendrikx wrote:
>> Region has floor and ceiling functions that ensure that calling them twice
>> in a row will yield the same result:
>>
>> ceil(x) = ceil(ceil(x))
>>
>> However, due to use of a constant `EPSILON` which is added/subtracted before
> Region has floor and ceiling functions that ensure that calling them twice in
> a row will yield the same result:
>
> ceil(x) = ceil(ceil(x))
>
> However, due to use of a constant `EPSILON` which is added/subtracted before
> doing the rounding, this only works for small numbers (in the
12 matches
Mail list logo
