Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-11 Thread Andy Goryachev
On Sat, 9 Mar 2024 06:08:34 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/css/FixedCapacitySet.java >> line 96: >> >>> 94: : maximumCapacity == 2 ? new Duo<>() >>> 95: : maximumCapacity < 10 ? new Hashless<>(maximumCapacity) >>>

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-11 Thread Kevin Rushforth
On Mon, 11 Mar 2024 16:23:46 GMT, Andy Goryachev wrote: >> I'd like someone else to weigh in on this. If this were a `Set` that >> eventually would be publicly accessible somewhere (by normal FX users) I'd >> definitely not want this. In this case however, it is (for now at least) >> only

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-11 Thread Andy Goryachev
On Mon, 11 Mar 2024 16:01:13 GMT, John Hendrikx wrote: >> But it is somewhat visible: **public** `void freeze();` (although it cannot >> be invoked directly). >> >> Edit: While I accept your reasoning that the functionality is effectively >> hidden from the user, I still think that the

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-11 Thread John Hendrikx
On Mon, 11 Mar 2024 14:54:45 GMT, Andy Goryachev wrote: >> I'm not against adding an explanation, but it's not needed as this is part >> of the `Set` contract (sets that can't be modified are specified to throw >> `UnsupportedOperationException`), for example for `add` in `Set`: >> >> *

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-11 Thread Andy Goryachev
On Sat, 9 Mar 2024 05:26:33 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/css/FixedCapacitySet.java >> line 135: >> >>> 133: protected final void ensureNotFrozen() { >>> 134: if (frozen) { >>> 135: throw new

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-08 Thread John Hendrikx
On Sat, 9 Mar 2024 00:04:04 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize performance of OpenAddressed Set just in case it is ever used > >

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-08 Thread John Hendrikx
On Fri, 8 Mar 2024 23:46:16 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize performance of OpenAddressed Set just in case it is ever used > >

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-08 Thread John Hendrikx
On Fri, 8 Mar 2024 23:26:05 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize performance of OpenAddressed Set just in case it is ever used > >

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-08 Thread John Hendrikx
On Fri, 8 Mar 2024 23:17:28 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize performance of OpenAddressed Set just in case it is ever used > >

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-08 Thread John Hendrikx
On Fri, 8 Mar 2024 23:14:12 GMT, Andy Goryachev wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Optimize performance of OpenAddressed Set just in case it is ever used > >

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-08 Thread Andy Goryachev
On Sun, 25 Feb 2024 22:28:12 GMT, John Hendrikx wrote: >> Improves performance of selector matching in the CSS subsystem. This is done >> by using custom set implementation which are highly optimized for the most >> common cases where the number of selectors is small (most commonly 1 or 2).

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-03-08 Thread Marius Hanl
On Sun, 25 Feb 2024 22: 28: 12 GMT, John Hendrikx wrote: >> Improves performance of selector matching in the CSS subsystem. This is done by using custom set implementation which are highly optimized for the ZjQcmQRYFpfptBannerStart This Message Is From an External

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v5]

2024-02-25 Thread John Hendrikx
> Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It also should be more memory efficient for medium sized