On Sun, 14 Jan 2024 16:06:42 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show d
On Fri, 19 Jan 2024 12:37:48 GMT, Marius Hanl wrote:
> Ahh, makes sense, thanks. First time backporting. :)
Yeah, and it's somewhat confusing to have jfx22u active during RDP1 of JavaFX
22 where most fixes that go back into the 22 code line will want to go into 22
GA rather than 22.0.1. I had
On Thu, 18 Jan 2024 16:41:31 GMT, Kevin Rushforth wrote:
> So I recommend abandoning the above PR and instead target the jfx22 branch of
> the jfx repo: `/backport jfx jfx22` instead.
Ahh, makes sense, thanks. First time backporting. :)
I deleted the backport branch in jfx22u.
-
P
On Sun, 14 Jan 2024 16:06:42 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show d
On Wed, 17 Jan 2024 15:28:53 GMT, Andy Goryachev wrote:
> backport instructions:
> https://openjdk.org/guide/#working-with-backports-in-jbs
See also
https://mail.openjdk.org/pipermail/openjfx-dev/2024-January/044529.html which
has additional information.
> @kevinrushforth there is still time
On Sun, 14 Jan 2024 16:06:42 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show d
On Tue, 16 Jan 2024 16:00:28 GMT, Andy Goryachev wrote:
> looks good now, thanks! should the fix be backported to jfx22?
Sounds good. I can do that, just need to find the instructions again.
-
PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-1895711865
On Sun, 14 Jan 2024 16:06:42 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show d
On Sun, 14 Jan 2024 16:06:42 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show d
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has refreshed the contents of this pull request, and previous
commits have been removed. The incremental views will show differences compared
to the previous content of the PR. The pull
On Thu, 11 Jan 2024 20:10:19 GMT, Andy Goryachev wrote:
> I think the problem is that we are trying to address two issues in one PR -
> the fix and migration to junit5. It might be better to go back one commit
> (but keep the most recent changes on a separate branch), convert the fix to
> use
On Thu, 11 Jan 2024 19:50:49 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: migrate
On Thu, 11 Jan 2024 19:57:21 GMT, Andy Goryachev wrote:
> Would it be possible to separate the migration from the fix?
Another idea could be to use the full qualified path:
`@org.junit.jupiter.api.Test`. But `@Before` and `@After` are still JUnit 4.
Or we can reduce the change by at least rever
On Thu, 11 Jan 2024 19:50:49 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: migrate
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8323543: migrates tests to junit 5
-
Changes:
- all: https://git.ope
On Thu, 11 Jan 2024 18:56:13 GMT, Kevin Rushforth wrote:
> Although... I just spotted something. The updated tests use JUnit5 assertions
> into what is otherwise a JUnit4 test. We generally avoid doing this.
Should we use the JUnit5 `@Test` annotation, or migrate the class to JUnit5?
The migra
On Thu, 11 Jan 2024 18:56:03 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - JDK-8323543: refac
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with two additional
commits since the last revision:
- JDK-8323543: refactors tests and adds accessible attribute test for treetable
- JDK-8
On Thu, 11 Jan 2024 18:33:45 GMT, Andy Goryachev wrote:
> This PR has a very narrow focus to be a candidate for a back port to jfx22
> @kevinrushforth
This seems a safe and targeted fix. I have no objection.
-
PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-18877682
On Thu, 11 Jan 2024 16:48:53 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: add tes
On Thu, 11 Jan 2024 18:53:16 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - JDK-8323543: refac
On Thu, 11 Jan 2024 18:49:42 GMT, Andy Goryachev wrote:
> @Maran23 would you like to double check and sponsor?
sure!
-
PR Comment: https://git.openjdk.org/jfx/pull/1329#issuecomment-1887764274
On Thu, 11 Jan 2024 16:48:53 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: add tes
On Thu, 11 Jan 2024 16:48:53 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: add tes
On Thu, 11 Jan 2024 16:48:53 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: add tes
On Thu, 11 Jan 2024 16:48:53 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: add tes
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8323543: add test and fix for another npe
-
Changes:
- all: https://
On Wed, 10 Jan 2024 19:09:47 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: clean u
On Wed, 10 Jan 2024 18:53:02 GMT, Carl Döbbelin wrote:
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
FYI: there is also a possibility of an NPE in
TableCellBehavior:70
TableView:2198
TableView:1922
I think we should add null checks there as w
On Wed, 10 Jan 2024 19:18:22 GMT, Carl Döbbelin wrote:
>> Carl Döbbelin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8323543: clean up code
>
> i will look into whether it is possible to generate a nullpointer with the
> current
On Wed, 10 Jan 2024 19:09:47 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: clean u
On Wed, 10 Jan 2024 19:09:47 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: clean u
On Wed, 10 Jan 2024 19:09:47 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543: clean u
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8323543: clean up code
-
Changes:
- all: https://git.openjdk.org/jfx
This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
items were null.
-
Commit messages:
- JDK-8323543: adds similar safety test in TreeTableViewTest
- JDK-8323543: Fixes Nullpointer in TableSkinUtils
Changes: https://git.openjdk.org/jfx/pull/1329/files
Webr
35 matches
Mail list logo
