On Thu, 11 Jan 2024 20:10:19 GMT, Andy Goryachev wrote:
> I think the problem is that we are trying to address two issues in one PR -
> the fix and migration to junit5. It might be better to go back one commit
> (but keep the most recent changes on a separate branch), convert the fix to
> use
On Thu, 11 Jan 2024 19:50:49 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543:
On Thu, 11 Jan 2024 19:57:21 GMT, Andy Goryachev wrote:
> Would it be possible to separate the migration from the fix?
Another idea could be to use the full qualified path:
`@org.junit.jupiter.api.Test`. But `@Before` and `@After` are still JUnit 4.
Or we can reduce the change by at least
On Thu, 11 Jan 2024 19:50:49 GMT, Carl Döbbelin wrote:
>> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
>> items were null.
>
> Carl Döbbelin has updated the pull request incrementally with one additional
> commit since the last revision:
>
> JDK-8323543:
> This PR fixes a nullpointer in TableSkinUtils that occured when the Tables
> items were null.
Carl Döbbelin has updated the pull request incrementally with one additional
commit since the last revision:
JDK-8323543: migrates tests to junit 5
-
Changes:
- all:
