On Tue, 13 Feb 2024 13:33:36 GMT, John Hendrikx wrote:
> CSR was created
I reviewed the CSR.
-
PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1943718956
On Sat, 10 Feb 2024 15:13:44 GMT, Kevin Rushforth wrote:
>>> > need 2 passes, because there already is a method named like that:
>>>
>>> oh yeah, sorry. `getStyleClassesSet()` ?
>>
>> That one is still available yes :)
>
> @hjohn I'm now leaning towards either `getStyleClassNames` or
> `getCla
On Mon, 5 Feb 2024 22:25:36 GMT, John Hendrikx wrote:
>>> need 2 passes, because there already is a method named like that:
>>
>> oh yeah, sorry.
>> `getStyleClassesSet()` ?
>
>> > need 2 passes, because there already is a method named like that:
>>
>> oh yeah, sorry. `getStyleClassesSet()` ?
>
On Mon, 5 Feb 2024 22:22:25 GMT, Andy Goryachev wrote:
> > need 2 passes, because there already is a method named like that:
>
> oh yeah, sorry. `getStyleClassesSet()` ?
That one is still available yes :)
-
PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1928279865
On Mon, 5 Feb 2024 22:14:06 GMT, John Hendrikx wrote:
> need 2 passes, because there already is a method named like that:
oh yeah, sorry.
`getStyleClassesSet()` ?
-
PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1928264474
On Fri, 2 Feb 2024 16:00:28 GMT, Kevin Rushforth wrote:
> I think `getClasses` is fine. My second choice would be `getClassNames`.
Perhaps it might be `getStyleClasses()` to parallel one in `Node`?
(I don't know why Node's method is called `getStyleClass` (singular) when it
clearly returns mult
On Mon, 5 Feb 2024 17:19:35 GMT, Andy Goryachev wrote:
> > I think `getClasses` is fine. My second choice would be `getClassNames`.
>
> Perhaps it might be `getStyleClasses()` to parallel one in `Node`? (I don't
> know why Node's method is called `getStyleClass` (singular) when it clearly
> re
On Fri, 2 Feb 2024 19:04:33 GMT, John Hendrikx wrote:
>>> My conclusion is that we either need two rounds to get this right (to first
>>> free up our first choice getStyleClasses), or we can settle on one of:
>>> getStyleClassNames, getStyles, getStyleNames, getClasses, getClassNames.
>>
>> Le
On Fri, 2 Feb 2024 16:00:28 GMT, Kevin Rushforth wrote:
> There is one other method used by SceneBuilder's `CssInternal` class,
> `CompoundSelector::getSelectors`. I think you need to add a method to the
> `Selector` base class that returns a `List` instead of the
> `List` returned by the exis
On Fri, 2 Feb 2024 13:27:50 GMT, John Hendrikx wrote:
> My conclusion is that we either need two rounds to get this right (to first
> free up our first choice getStyleClasses), or we can settle on one of:
> getStyleClassNames, getStyles, getStyleNames, getClasses, getClassNames.
Let's settle o
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 17:54:17 GMT, Andy Goryachev wrote:
> > Scene Builder releases are always tight to the JavaFX version
>
> Thank you for clarification! Still, there might be other tools out there that
> we don't know of.
That's always possible. I couldn't find anything with an internet sea
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 17:52:31 GMT, Jose Pereda wrote:
> Scene Builder releases are always tight to the JavaFX version
Thank you for clarification!
Still, there might be other tools out there that we don't know of.
-
PR Comment: https://git.openjdk.org/jfx/pull/1340#issuecomment-1900
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
On Fri, 19 Jan 2024 16:00:49 GMT, John Hendrikx wrote:
>> The SimpleSelector and CompoundSelector classes are public classes in an
>> exported package, javafx.css, but they are not intended to be used by
>> applications. They are implementation details. They cannot be constructed
>> directly a
> The SimpleSelector and CompoundSelector classes are public classes in an
> exported package, javafx.css, but they are not intended to be used by
> applications. They are implementation details. They cannot be constructed
> directly and no other JavaFX API accepts or returns a SimpleSelector or
20 matches
Mail list logo
