On Tue, 26 Mar 2024 20:53:17 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve (stub) font tests, fallback and documentation
>
> modules/javafx.graphics/src/test/java/test/com/sun/javafx/pg
On Tue, 26 Mar 2024 20:47:37 GMT, Marius Hanl wrote:
>> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
>> of the stub font implementation. As I don't want to clutter the PR with
>> that, I decided to cherrypick the improvements I did to a new ticket and PR.
>>
>> T
On Tue, 26 Mar 2024 20:36:02 GMT, Andy Goryachev wrote:
>> I can also use `round` here. Seems to be a bit safer, I agree.
>
> thank you.
>
> one more question - is it possible to set fractional scale with the
> StubToolkit, and how would that work in the StubFontLoader? Does it mean
> we'll b
On Tue, 26 Mar 2024 20:47:37 GMT, Marius Hanl wrote:
>> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
>> of the stub font implementation. As I don't want to clutter the PR with
>> that, I decided to cherrypick the improvements I did to a new ticket and PR.
>>
>> T
On Mon, 25 Mar 2024 23:00:25 GMT, Marius Hanl wrote:
>> modules/javafx.graphics/src/test/java/test/com/sun/javafx/pgstub/StubFontLoader.java
>> line 76:
>>
>>> 74: FontHelper.setNativeFont(font, nativeFont,
>>> font.getName(), "Amble LtCn", "Regular");
>>> 75: c
> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
> of the stub font implementation. As I don't want to clutter the PR with that,
> I decided to cherrypick the improvements I did to a new ticket and PR.
>
> The current implementation has the following shortcomings:
>