Re: List scrolling is very slow in JavaFX 17

2022-11-22 Thread Johan Vos
Update: I had a quick look, downloaded the code and for a single scroll event, there are 74 calls to updateItem. However, 69 of those are invoked via `com.jfoenix.skins.JFXListViewSkin.estimateHeight` which calls `com.jfoenix.adapters.VirtualFlowHelper.forEach` which calls into `VirtualFlow.setCell

Re: List scrolling is very slow in JavaFX 17

2022-11-22 Thread Johan Vos
Hi Glavo, I could see there are many UI-related operations in some of the updateItems -- room for improvement that we can discuss off-list. Having said that, I agree with the confusing part about updateItem being called without the item being rendered. - Johan On Tue, Nov 22, 2022 at 12:17 PM G

Re: List scrolling is very slow in JavaFX 17

2022-11-22 Thread Johan Vos
Hi Craig, That boils down to the same issue I described earlier in this thread, and that is also mentioned on https://bugs.openjdk.org/browse/JDK-8280442. I agree the workaround does not look pretty (I suggested it myself), but the fact that it works is not by accident. There is indeed a differenc

Re: List scrolling is very slow in JavaFX 17

2022-11-22 Thread Craig Raw
I encountered the same problem and described my solution here: https://mail.openjdk.org/pipermail/openjfx-dev/2022-July/034764.html It's not pretty but it does seem to work. On Tue, Nov 22, 2022 at 1:18 PM Glavo wrote: > We created an advanced list with titles, subtitles, icons, and tags, and >

Re: List scrolling is very slow in JavaFX 17

2022-11-22 Thread Glavo
We created an advanced list with titles, subtitles, icons, and tags, and updated these contents in the updateItem. I took a screenshot of it and uploaded it as a comment to GitHub next to the relevant code: https://github.com/huanghongxun/HMCL/pull/1849/commits/4f8cde63acf959d85416b706acf22f9b3c8

Aw: Re: List scrolling is very slow in JavaFX 17

2022-11-22 Thread Marius Hanl
. November 2022 um 10:58 Uhr Von: "John Hendrikx" An: openjfx-dev@openjdk.org Betreff: Re: List scrolling is very slow in JavaFX 17 I took a quick look, I didn't see any Node creation, the updateItem calls look pretty normal (setting some labels and a list of tags). I downloaded

Re: List scrolling is very slow in JavaFX 17

2022-11-22 Thread John Hendrikx
I took a quick look, I didn't see any Node creation, the updateItem calls look pretty normal (setting some labels and a list of tags). I downloaded the application and installed the application (it's nicely packaged) and clicked on "download" which shows the problematic list.  It indeed perfor

Re: List scrolling is very slow in JavaFX 17

2022-11-22 Thread Johan Vos
Hi Glavo, There are more frequent calls to updateItem() since the VirtualFlow tries to gradually improve its estimation how large the total list size is (rather than assuming all cells have the same size). The major point is that if you override updateItem, it should not do more than strictly need