Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-07-23 Thread Tim Bentley
Review: Approve Approved by me. -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/30848 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-07-23 Thread Jon Tibble
The proposal to merge lp:~meths/openlp/trivialfixes into lp:openlp has been updated. Description changed to: Cleanups and refactor bibles: * Remove wildcard import * Remove unnecessary getters and setters * Refactor BibleGateway retrieval * Fix advanced bible search (Bug # 608409) -- https://co

[Openlp-core] [Bug 608409] Re: bible web "search" does not work

2010-07-23 Thread Jon Tibble
The fix committed is a temporary fix that uses the HTTPBooks database resource to populate the advanced search page. This will be refactored when we have web bibles downloading their own books to enable full bible localisation. ** Changed in: openlp Status: Incomplete => Fix Committed --

[Openlp-core] [Bug 609356] Re: Web bibles don't download all their books on import

2010-07-23 Thread Jon Tibble
This is no longer a problem for searches (see Bug #608409) but is a problem for localisation as all the bible books are in English in the bibles resources database. -- Web bibles don't download all their books on import https://bugs.launchpad.net/bugs/609356 You received this bug notification bec

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-07-23 Thread Jon Tibble
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp. Requested reviews: Tim Bentley (trb143) Cleanups: * Remove wildcard import * Remove unnecessary getters and setters * Refactor BibleGateway retrieval -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/3

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-07-23 Thread Jon Tibble
The proposal to merge lp:~meths/openlp/trivialfixes into lp:openlp has been updated. Status: Needs review => Superseded -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/30847 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Bug 609354] [NEW] Books with preceeding numbers don't work with web bibles (e.g. 1 Kings)

2010-07-23 Thread Jon Tibble
Public bug reported: When searching for verses from a web bible (only tested with BG) they are not found. The URL looks fine and the book gets added to the book table but no verses are saved to the DB or shown to the user. There is also no stack trace or indication to the user of failure except

[Openlp-core] [Bug 609355] [NEW] Dual language bible search results and service items don't indicate duality

2010-07-23 Thread Jon Tibble
Public bug reported: When using two languages the search results only show one version name and the service item doesn't show any versions which makes confirmation of what you are doing harder than it should be. ** Affects: openlp Importance: Undecided Status: New -- Dual language

[Openlp-core] [Bug 609356] [NEW] Web bibles don't download all their books on import

2010-07-23 Thread Jon Tibble
Public bug reported: When importing a web bible the books are not all downloaded at once which makes the advanced search useless as not all the books are there and the ones that are, are not put in the correct order. ** Affects: openlp Importance: Undecided Status: New -- Web bibl

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-07-23 Thread Jon Tibble
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp. Requested reviews: Tim Bentley (trb143) Cleanups: * Remove wildcard import * Remove unnecessary getters and setters * Refactor BibleGateway retrieval -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/3

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-07-23 Thread Jon Tibble
The proposal to merge lp:~meths/openlp/trivialfixes into lp:openlp has been updated. Status: Needs review => Superseded -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/30737 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/string-fixes into lp:openlp

2010-07-23 Thread Tim Bentley
Review: Approve Approved -- https://code.launchpad.net/~raoul-snyman/openlp/string-fixes/+merge/30814 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad

[Openlp-core] [Bug 608409] Re: bible web "search" does not work

2010-07-23 Thread googol
Well, forget about the two bugs Here an image to show the problem: http://img638.imageshack.us/i/imagepiu.png/ I traced the problem down to rev894. ** Description changed: Hello! - I am running xubuntu with trunk revision 958. I am using a web bible - (web import). + I am running xubun

[Openlp-core] [Bug 608409] Re: bible web "search" does not work

2010-07-23 Thread googol
** Summary changed: - bible search does not work + bible web "search" does not work -- bible web "search" does not work https://bugs.launchpad.net/bugs/608409 You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. Status in OpenLP - Worship Pr

[Openlp-core] [Bug 608409] Re: bible search does not work

2010-07-23 Thread googol
I think there are actually two issues here. I think I will file another bug report. -- bible search does not work https://bugs.launchpad.net/bugs/608409 You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. Status in OpenLP - Worship Presentat

[Openlp-core] [Merge] lp:~meths/openlp/docs into lp:openlp

2010-07-23 Thread noreply
The proposal to merge lp:~meths/openlp/docs into lp:openlp has been updated. Status: Approved => Merged -- https://code.launchpad.net/~meths/openlp/docs/+merge/30736 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https:/

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-07-23 Thread Jon Tibble
I'm thinking the text = str(soup.find(u'div', u'result-text-style-normal')) looks like a bit of a first draft. If anyone has easy access to bibles with interesting chars could they see (probably confirm) this breaks and try: text = unicode(soup.find(u'div', u'result-text-style-normal')).decod

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes into lp:openlp

2010-07-23 Thread phill
With out my code clicking start loop whilst the screen is blanked or themed, starts the loop in the live controller, but does not show up on the main diaplay. However when the desktop is being shown, clicking start loop starts the loop in the live contoller, as well as displaying the images on the

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/ui-tweaks into lp:openlp

2010-07-23 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/ui-tweaks into lp:openlp has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~raoul-snyman/openlp/ui-tweaks/+merge/30712 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes into lp:openlp

2010-07-23 Thread Jonathan Corwin
We also need to confirm this is expected behaviour. I.e. if someone presses the start loop button when blanked, they may be just indicating their wish that it will loop when they later press the unblank button. Personally when I hit blank, I don't expect anything to show on the screen, no matter

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes into lp:openlp

2010-07-23 Thread phill
Valid point! No I don't think it is! Will try to look at that tomorrow, if not tonight! On 23 Jul 2010 09:14, "Jonathan Corwin" wrote: Review: Needs Information Sorry not in a position to try it myself. Is the blank button reset correctly when the maindisplay_show signal is sent? -- https://co

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/fixes into lp:openlp

2010-07-23 Thread Jonathan Corwin
Review: Needs Information Sorry not in a position to try it myself. Is the blank button reset correctly when the maindisplay_show signal is sent? -- https://code.launchpad.net/~phill-ridout/openlp/fixes/+merge/30726 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/ui-tweaks into lp:openlp

2010-07-23 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/ui-tweaks/+merge/30712 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubs

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-07-23 Thread Raoul Snyman
I'm going to have to test this out (probably tonight)... -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/30737 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : op

[Openlp-core] [Merge] lp:~meths/openlp/docs into lp:openlp

2010-07-23 Thread Raoul Snyman
The proposal to merge lp:~meths/openlp/docs into lp:openlp has been updated. Status: Needs review => Approved -- https://code.launchpad.net/~meths/openlp/docs/+merge/30736 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: h

Re: [Openlp-core] [Merge] lp:~meths/openlp/docs into lp:openlp

2010-07-23 Thread Raoul Snyman
Review: Approve approve great! -- https://code.launchpad.net/~meths/openlp/docs/+merge/30736 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu