Re: [Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Tim Bentley
Review: Approve Approved -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/35593 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpa

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bugfixing into lp:openlp

2010-09-15 Thread Tim Bentley
Suggest you move the openlp.pyw fix in here as well as getting a bug fix in will be easier than leaving it with the i18n stuff -- https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35588 Your team OpenLP Core is subscribed to branch lp:openlp. __

Re: [Openlp-core] [Merge] lp:~crichter/openlp/i18n into lp:openlp

2010-09-15 Thread Raoul Snyman
Review: Needs Fixing This doesn't make sense: def setPluginStrings(self): """ Called to define all translatable texts of the plugin """ self.name = u'Plugin' self.name_lower = u'plugin' self.strings = {} In this method you have put things that b

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bugfixing into lp:openlp

2010-09-15 Thread Raoul Snyman
Review: Needs Fixing This does not look correct. Your connection strings will end up looking like this: openoffice.org -nologo -norestore -minimized -invisible -nofirststartwizard -accept="pipe,name=openlp_pipe:socket,host=localhost,port=2002;urp;" and uno:pipe,name=openlp_pipe:,host=loca

[Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Raoul Snyman
The proposal to merge lp:~mjthompson/openlp/opensong_import into lp:openlp has been updated. Status: Needs review => Approved -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/35593 Your team OpenLP Core is subscribed to branch lp:openlp. __

Re: [Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Raoul Snyman
Review: Approve approve -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/35593 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpa

[Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Martin Thompson
Martin Thompson has proposed merging lp:~mjthompson/openlp/opensong_import into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Integrated with the song import wizard. More testcases with synthetic data. More testing done with more real data. -- https://code.

[Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Martin Thompson
The proposal to merge lp:~mjthompson/openlp/opensong_import into lp:openlp has been updated. Status: Needs review => Superseded -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/35587 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~crichter/openlp/i18n into lp:openlp

2010-09-15 Thread Jon Tibble
Review: Needs Fixing Don't define stuff that conflicts with built in types (types.StringType) - that way lies madness. -- https://code.launchpad.net/~crichter/openlp/i18n/+merge/35565 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Merge] lp:~crichter/openlp/bugfixing into lp:openlp

2010-09-15 Thread rimach
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp. Requested reviews: OpenLP Core (openlp-core) change using of pipe instead of socket for soffice communication via uno. -- https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/35588 Your team OpenLP Core is requ

[Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Martin Thompson
Martin Thompson has proposed merging lp:~mjthompson/openlp/opensong_import into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Integrated with the song import wizard. More testcases with synthetic data. More testing done with more real data. -- https://code.

[Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Martin Thompson
The proposal to merge lp:~mjthompson/openlp/opensong_import into lp:openlp has been updated. Status: Needs review => Superseded -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/35581 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Tim Bentley
Review: Needs Fixing Merge errors. -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/35581 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@list

[Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Martin Thompson
Martin Thompson has proposed merging lp:~mjthompson/openlp/opensong_import into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Integrated with the song import wizard. More testcases with synthetic data. More testing done with more real data. -- https://code.

[Openlp-core] [Merge] lp:~mjthompson/openlp/opensong_import into lp:openlp

2010-09-15 Thread Martin Thompson
The proposal to merge lp:~mjthompson/openlp/opensong_import into lp:openlp has been updated. Status: Needs review => Superseded -- https://code.launchpad.net/~mjthompson/openlp/opensong_import/+merge/35330 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~crichter/openlp/i18n into lp:openlp

2010-09-15 Thread rimach
1. I tested the latest trunk with the Changes from Raoul. He added a new option regarding the exception window. Here I use python 2.5 and get now this error message: File "openlp.pyw", line 217, in main() File "openlp.pyw", line 168, in main action='store_true', help='Disable the erro

Re: [Openlp-core] [Merge] lp:~crichter/openlp/i18n into lp:openlp

2010-09-15 Thread Tim Bentley
Review: Needs Fixing Why are you changing openlp.pyw Line 102 ? Why is plugin manager looking at media_item_string. 562 and friends says set a value , then translate it and set it again. -- https://code.launchpad.net/~crichter/openlp/i18n/+merge/35565 Your team OpenLP Core is subscribed to bra

[Openlp-core] [Merge] lp:~crichter/openlp/i18n into lp:openlp

2010-09-15 Thread rimach
The proposal to merge lp:~crichter/openlp/i18n into lp:openlp has been updated. Status: Needs review => Superseded -- https://code.launchpad.net/~crichter/openlp/i18n/+merge/35457 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Bug 633354] Re: Song Importer Broke

2010-09-15 Thread Raoul Snyman
** Changed in: openlp Status: Fix Committed => Fix Released -- Song Importer Broke https://bugs.launchpad.net/bugs/633354 You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. Status in OpenLP - Worship Presentation Software: Fix Releas

[Openlp-core] [Bug 635515] Re: New Error Handling window crashes

2010-09-15 Thread Raoul Snyman
** Changed in: openlp Status: Fix Committed => Fix Released -- New Error Handling window crashes https://bugs.launchpad.net/bugs/635515 You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. Status in OpenLP - Worship Presentation Softwa

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/except-hook into lp:openlp

2010-09-15 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/except-hook into lp:openlp has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~raoul-snyman/openlp/except-hook/+merge/35463 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/except-hook into lp:openlp

2010-09-15 Thread Jon Tibble
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/except-hook/+merge/35463 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/except-hook into lp:openlp

2010-09-15 Thread Tim Bentley
Review: Approve Ah thats what Jon meant by alignment issues ;-) -- https://code.launchpad.net/~raoul-snyman/openlp/except-hook/+merge/35463 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Pos