Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/OpenLyrics into lp:openlp

2011-01-10 Thread Tim Bentley
Review: Approve Approved. We does only support one song book, so take the first one should be We only support one song book, so take the first one -- https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~m2j/openlp/work into lp:openlp

2011-01-10 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~m2j/openlp/work/+merge/45653 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2011-01-10 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/45650 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/OpenLyrics into lp:openlp

2011-01-10 Thread Raoul Snyman
Review: Approve You might want to return None instead of 0 if there's no XML, and do if song_id is None, but that's just semantics. -- https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~m2j/openlp/work into lp:openlp

2011-01-10 Thread noreply
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~m2j/openlp/work/+merge/45653 -- https://code.launchpad.net/~m2j/openlp/work/+merge/45653 Your team OpenLP Core is subscribed to branch

[Openlp-core] [Merge] lp:~googol-hush/openlp/OpenLyrics into lp:openlp

2011-01-10 Thread noreply
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646 -- https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/45646

[Openlp-core] [Bug 698871] Re: theme import shows black on sides of thumbnail

2011-01-10 Thread John Cegalis
Tim, I have confirmed this issue on Win7, XP and 1.9.4 and kubuntu Exact steps taken. Single monitor, (don't know if that makes a difference) I changed my override display settings to 800x600 then imported my theme. It imported like my image in #1 above. I then changed the override display

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

2011-01-10 Thread Tim Bentley
No Calls to setQuickMessage removed? -- https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/45704 Your team OpenLP Core is requested to review the proposed merge of lp:~googol-hush/openlp/bibles into lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

2011-01-10 Thread Raoul Snyman
Review: Needs Fixing 48 + }) Needs to be unindented one level. -- https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/45704 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

2011-01-10 Thread Andreas Preikschat
That's correct. I did not find any place where it's called. andr...@andypc:~/Projekte/openlp/trunk$ cg setQuickMessage *.py 0 openlp/plugins/bibles/lib/mediaitem.py 350 def setQuickMessage(self, text): -- https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/45704 Your team OpenLP Core

[Openlp-core] [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

2011-01-10 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/bibles into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/45713 Hello! - removed the quick message and added dialogs instead - send

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

2011-01-10 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/45713 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Bug 700859] Re: Bible importers do not clean up properly after a failed import

2011-01-10 Thread Raoul Snyman
** Changed in: openlp Status: New = Confirmed ** Changed in: openlp Importance: Undecided = Medium ** Changed in: openlp Assignee: (unassigned) = Raoul Snyman (raoul-snyman) ** Changed in: openlp Milestone: None = 1.9.4 -- You received this bug notification because you are

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2011-01-10 Thread noreply
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~trb143/openlp/bugs/+merge/45650 -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/45650 Your team OpenLP Core is subscribed

[Openlp-core] [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

2011-01-10 Thread noreply
The proposal to merge lp:~googol-hush/openlp/bibles into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/45713 -- https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/45713 Your team

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2011-01-10 Thread Tim Bentley
Review: Approve Approve -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/45657 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2011-01-10 Thread noreply
The proposal to merge lp:~meths/openlp/trivialfixes into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/45657 -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/45657 Your team

[Openlp-core] [Bug 700859] Re: Bible importers do not clean up properly after a failed import

2011-01-10 Thread Raoul Snyman
** Changed in: openlp Milestone: 1.9.4 = 1.9.5 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/700859 Title: Bible importers do not clean up properly after a failed import Status in OpenLP -

[Openlp-core] [Bug 700089] Re: RFE: Should be able to delete themes with associations

2011-01-10 Thread Tim Bentley
** Changed in: openlp Status: Confirmed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/700089 Title: RFE: Should be able to delete themes with associations Status in OpenLP -

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2011-01-10 Thread Jon Tibble
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/45780 More cleaning... --

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2011-01-10 Thread Raoul Snyman
Review: Approve This is fine, but can we try not to have formatting wars? It seems that every second merge proposal has some reformatting in it. -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/45780 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Bug 701353] [NEW] Bibles do not show on the live screen when transitions are turned on in the theme

2011-01-10 Thread Raoul Snyman
Public bug reported: To reproduce: 1. Edit or create a theme, setting transitions on. 2. Select a verse range from your Bibles media item. 3. Add the verse range to your service manager. 4. Go live on the Bible and notice there are no words. 5. Edit your theme again, setting transitions off. 6.