Review: Needs Fixing
Who left a print statement in then!
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46874
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Who left a print statement in then!
The print statements belong to the print_song() method.
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46874
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
You have moved code from song initialisation to Form initialisation what
happens when a second song is loaded? Does the for set it self up correctly?
I don't understand what you mean? But the songmaintance dialog loads as it is
supposed to.
--
I do not understand lines 393-395. Why did you add the code?
screenSizeChanged() calls previewSizeChanged() which takes care of the size.
And at the time you set the size the screen ratio is not updated (this happens
a few lines later).
--
@Jon: I will remove these points
@Andreas: Sorry, this is only a merge failure, I don't want change anything
regarding the screensize
--
https://code.launchpad.net/~crichter/openlp/shortcut-dialog/+merge/46833
Your team OpenLP Core is subscribed to branch lp:openlp.
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/fixes into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#598393 After adding a new image to a selected (image) item in the service
manager it is not selected anymore
Tried it out now and seems OK.
--
https://code.launchpad.net/~googol-hush/openlp/songs/+merge/46875
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to :
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/OpenLyrics into
lp:openlp.
Requested reviews:
Jon Tibble (meths)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46948
Hello!
- The reindex tool removes the language
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46948
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
--
https://code.launchpad.net/~crichter/openlp/shortcut-dialog/+merge/46949
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Public bug reported:
As reported on the forum
(http://openlp.org/en/forums/openlp_20/bug_reports/bible_search_issues.html)
and I've just confirmed, when searching multiple chapters (at least,
haven't done exhaustive testing yet) you get incorrect results.
e.g. genesis 1-10 returned 1-8,10
**
The proposal to merge lp:~googol-hush/openlp/OpenLyrics into lp:openlp has been
updated.
Status: Needs review = Merged
For more details, see:
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46948
--
https://code.launchpad.net/~googol-hush/openlp/OpenLyrics/+merge/46948
Review: Approve
--
https://code.launchpad.net/~googol-hush/openlp/songs/+merge/46875
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
13 matches
Mail list logo
