Re: [Openlp-core] [Merge] lp:~mahfiaz/openlp/fixes_and_improvements into lp:openlp

2011-02-23 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~mahfiaz/openlp/fixes_and_improvements/+merge/50813 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/foilpresenterimport into lp:openlp

2011-02-23 Thread Tim Bentley
Review: Needs Fixing sortnr should be True/False not 1/0 in the code regardless of the value in the XML line 550 -- https://code.launchpad.net/~orangeshirt/openlp/foilpresenterimport/+merge/50806 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-02-23 Thread Andreas Preikschat
The proposal to merge lp:~googol-hush/openlp/trivial into lp:openlp has been updated. Description changed to: Hello! The re-index tool adds 'Author unknown' if songs do not have any author. Cheers For more details, see: https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50459 --

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-02-23 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/trivial into lp:openlp. Requested reviews: Jon Tibble (meths) Tim Bentley (trb143) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50966 Hello! The re-index

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-02-23 Thread Jon Tibble
Review: Needs Fixing Please add a utility method, something like add_unknown_author(), rather than adding the same piece of code in three places. Could you also take care of the unknown author adding in olpimport.py with this patch please. --

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-02-23 Thread Andreas Preikschat
Please add a utility method, something like add_unknown_author(), rather than adding the same piece of code in three places. Yes, I thought about it, but I have not found a place to add it. Could you also take care of the unknown author adding in olpimport.py with this patch please. olpimport

Re: [Openlp-core] [Merge] lp:~mahfiaz/openlp/fixes_and_improvements into lp:openlp

2011-02-23 Thread Jon Tibble
Review: Approve -- https://code.launchpad.net/~mahfiaz/openlp/fixes_and_improvements/+merge/50813 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

[Openlp-core] [Merge] lp:~orangeshirt/openlp/foilpresenterimport into lp:openlp

2011-02-23 Thread Armin Köhler
Armin Köhler has proposed merging lp:~orangeshirt/openlp/foilpresenterimport into lp:openlp. Requested reviews: Andreas Preikschat (googol-hush) Tim Bentley (trb143) Jon Tibble (meths) For more details, see: https://code.launchpad.net/~orangeshirt/openlp/foilpresenterimport/+merge/50984

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-02-23 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/trivial into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Jon Tibble (meths) For more details, see: https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50994 Hello! The re-index

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/default-image into lp:openlp

2011-02-23 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/default-image into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/default-image/+merge/51010 Add the option to change the default display. --

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/default-image into lp:openlp

2011-02-23 Thread Tim Bentley
Review: Approve That was going to be my next change! -- https://code.launchpad.net/~raoul-snyman/openlp/default-image/+merge/51010 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-02-23 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50994 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/foilpresenterimport into lp:openlp

2011-02-23 Thread Tim Bentley
Review: Approve Can't see any problems from my POV -- https://code.launchpad.net/~orangeshirt/openlp/foilpresenterimport/+merge/50984 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-02-23 Thread Jon Tibble
Review: Approve -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50994 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/foilpresenterimport into lp:openlp

2011-02-23 Thread Jon Tibble
Review: Approve -- https://code.launchpad.net/~orangeshirt/openlp/foilpresenterimport/+merge/50984 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/default-image into lp:openlp

2011-02-23 Thread Jon Tibble
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/default-image/+merge/51010 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~mahfiaz/openlp/fixes_and_improvements into lp:openlp

2011-02-23 Thread noreply
The proposal to merge lp:~mahfiaz/openlp/fixes_and_improvements into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~mahfiaz/openlp/fixes_and_improvements/+merge/50813 --

[Openlp-core] [Merge] lp:~orangeshirt/openlp/foilpresenterimport into lp:openlp

2011-02-23 Thread noreply
The proposal to merge lp:~orangeshirt/openlp/foilpresenterimport into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~orangeshirt/openlp/foilpresenterimport/+merge/50984 --

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-02-23 Thread noreply
The proposal to merge lp:~googol-hush/openlp/trivial into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50994 -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/50994 Your team

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/default-image into lp:openlp

2011-02-23 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/default-image into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/default-image/+merge/51010 --

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2011-02-23 Thread Jon Tibble
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/51061 Cleanups and fixes --

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2011-02-23 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/51061 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~crichter/openlp/testing into lp:openlp

2011-02-23 Thread Raoul Snyman
Instead of creating a whole new widget, which does almost exactly what the dialog does, adapt the dialog to do what your widget does. -- https://code.launchpad.net/~crichter/openlp/testing/+merge/50461 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/copyright into lp:openlp

2011-02-23 Thread Tim Bentley
Review: Approve Approved -- https://code.launchpad.net/~raoul-snyman/openlp/copyright/+merge/51073 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :