Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/general into lp:openlp

2011-05-16 Thread Jonathan Corwin
> And change the label "Text:" to "Scripture Reference:" as we use this string > in OpenLP as well. > Not easy to do this. The search is generic across plugins, I didn't want to put any knowledge of them here. > Is it wanted that a song/bible... is send live when I click one item from the > se

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/general into lp:openlp

2011-05-16 Thread Andreas Preikschat
Review: Needs Fixing Hello, Could you replace 371-379 with something like this: if search_results: versetext = u' '.join([verse.text for verse in search_results]) return [string, versetext] return [] When I try to search a keyword in a bible I get this tra

[Openlp-core] [Bug 696707] Re: OpenType fonts don't work in Windows 7

2011-05-16 Thread Launchpad Bug Tracker
[Expired for OpenLP because there has been no activity for 60 days.] ** Changed in: openlp Status: Incomplete => Expired -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/696707 Title: OpenType

[Openlp-core] [Bug 706209] Re: Bibles: after a exception in a reference search the search button stays disabled

2011-05-16 Thread Launchpad Bug Tracker
[Expired for OpenLP because there has been no activity for 60 days.] ** Changed in: openlp Status: Incomplete => Expired -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/706209 Title: Bibles: a

Re: [Openlp-core] [Merge] lp:~trb143/openlp/b1 into lp:openlp

2011-05-16 Thread Jonathan Corwin
Review: Needs Fixing I've had a quick test of presentations. 1. I don't know what line 263 is for, but it causes it to crash. Removing it, and it is all happy again. 2. In presentations\lib\messagelistener.py I changed line 272 from file = os.path.join(item.get_frame_path(),

Re: [Openlp-core] [Merge] lp:~trb143/openlp/b1 into lp:openlp

2011-05-16 Thread Jonathan Corwin
Review: Needs Fixing OK, I can now add the two images fine. I then added the two same-named images to a service, and it differentiated the two fine. However after saving and re-opening the service, going live on either both showed the same image. -- https://code.launchpad.net/~trb143/openlp/b1/

[Openlp-core] [Merge] lp:~j-corwin/openlp/general into lp:openlp

2011-05-16 Thread Jonathan Corwin
Jonathan Corwin has proposed merging lp:~j-corwin/openlp/general into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Related bugs: Bug #634771 in OpenLP: "OpenLP 1.9.2+bzr1016-0ubuntu1~lucid1 does not start" https://bugs.launchpad.net/openlp/+bug/634771 Bu

Re: [Openlp-core] [Merge] lp:~gerald-britton/openlp/bugs into lp:openlp

2011-05-16 Thread jerryb
I did that just before I pushed it to Launchpad On Mon, May 16, 2011 at 3:17 PM, Jonathan Corwin wrote: > Please could you merge with latest trunk, and then we can see which are the > bits you've changed! Thanks. > -- > https://code.launchpad.net/~gerald-britton/openlp/bugs/+merge/61158 > You ar

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/general into lp:openlp

2011-05-16 Thread Raoul Snyman
Review: Needs Fixing 708 + searchPlugins: function (event) { Does this method actually perform the search, or just return a list of searchable plugins? If the latter, please rename it to something like "getSearchablePlugins". 799 + def plugin(self, action): Possibly rename this one too

Re: [Openlp-core] [Merge] lp:~gerald-britton/openlp/bugs into lp:openlp

2011-05-16 Thread Jonathan Corwin
Please could you merge with latest trunk, and then we can see which are the bits you've changed! Thanks. -- https://code.launchpad.net/~gerald-britton/openlp/bugs/+merge/61158 Your team OpenLP Core is requested to review the proposed merge of lp:~gerald-britton/openlp/bugs into lp:openlp. _

[Openlp-core] [Bug 752374] Re: zipping through service with arrows

2011-05-16 Thread John Cegalis
It is still a bug now that I checked again. Win7 1548 and Linux 1549 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/752374 Title: zipping through service with arrows Status in OpenLP - Worship Prese

[Openlp-core] [Merge] lp:~gerald-britton/openlp/bugs into lp:openlp

2011-05-16 Thread jerryb
jerryb has proposed merging lp:~gerald-britton/openlp/bugs into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~gerald-britton/openlp/bugs/+merge/61158 ** RFC only. Not ready for merging (and no rush to do so) *** This patch implemen

[Openlp-core] [Bug 780095] Re: audio/video isn't paused if going from preview to live from preview

2011-05-16 Thread Jonathan Springer
If you double click on the item in the preview pane it will go live. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/780095 Title: audio/video isn't paused if going from preview to live from preview

[Openlp-core] [Bug 745688] Re: Traceback when loading presentation with Powerpoint Viewer 2003

2011-05-16 Thread Jonathan Corwin
** Changed in: openlp Status: Incomplete => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/745688 Title: Traceback when loading presentation with Powerpoint Viewer 2003 Status in

[Openlp-core] [Bug 752374] Re: zipping through service with arrows

2011-05-16 Thread Tim Bentley
Please can you confirm if this is still a bug. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/752374 Title: zipping through service with arrows Status in OpenLP - Worship Presentation Software: Co

[Openlp-core] [Bug 780095] Re: audio/video isn't paused if going from preview to live from preview

2011-05-16 Thread Tim Bentley
How can this be achieved as the preview panel for media items does not have the ability to move an item to live. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/780095 Title: audio/video isn't paused

[Openlp-core] [Bug 745688] Re: Traceback when loading presentation with Powerpoint Viewer 2003

2011-05-16 Thread Stevan Pettit
This item has been fixed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/745688 Title: Traceback when loading presentation with Powerpoint Viewer 2003 Status in OpenLP - Worship Presentation Software

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/tweaks into lp:openlp

2011-05-16 Thread Jonathan Corwin
I would prefer to just see a "Rebuild theme thumbnails" option somewhere, to do a manual update if needed. There are some people who like to have one theme per song, so potentially could have lots. Everytime they unplug the projector at the end, it could take a while for this process to run for

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/tweaks into lp:openlp

2011-05-16 Thread Tim Bentley
Review: Needs Information Only the thumbnails will change but is that important. In the testing world this will slow things down but in the real world I agree with Jonathan that we will have themes changing at regular intervals. All that is changed is the shape of the image the theme file is not c

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/tweaks into lp:openlp

2011-05-16 Thread Jonathan Corwin
Review: Needs Information So I have my themes setup nicely for my projector and I then unplug projector and move to override display, so all my saved themes change? Will they definitely go back to their original state when I plug the projector back in? Also what happens if the screen setup chan

[Openlp-core] [Merge] lp:~googol-hush/openlp/tweaks into lp:openlp

2011-05-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/tweaks into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol-hush/openlp/tweaks/+merge/61102 Hello, Update the theme preview images if the screen setup changed. --

[Openlp-core] [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

2011-05-16 Thread noreply
The proposal to merge lp:~googol-hush/openlp/bibles into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/61018 -- https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/61018 Your team OpenLP Co