Re: [Openlp-core] [Merge] lp:~googol/openlp/tweaks into lp:openlp

2011-06-27 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/tweaks/+merge/65889 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~trb143/openlp/lock-toolbar into lp:openlp

2011-06-27 Thread Raoul Snyman
Review: Needs Fixing 76 + translate('OpenLP.MainWindow', 'Prevent the Panels being moved.')) panels. -- https://code.launchpad.net/~trb143/openlp/lock-toolbar/+merge/65890 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~googol/openlp/tweaks into lp:openlp

2011-06-27 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/tweaks into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol/openlp/tweaks/+merge/65889 -- https://code.launchpad.net/~googol/openlp/tweaks/+merge/65889 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/image-queue into lp:openlp

2011-06-27 Thread Raoul Snyman
Review: Needs Fixing You've changed _clean_cache() to _process_cache(), can you also change _clean_queue to something else? Maybe _conversion_queue, or something else a little more descriptive. _clean_queue make it sound like the images are dirty as opposed to unprocessed or unconverted. --

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-06-27 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/65899 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-06-27 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/65899 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/65899 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

2011-06-27 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/65901 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

2011-06-27 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial2 into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial2/+merge/65901 -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/65901 Your team OpenLP Core

Re: [Openlp-core] [Merge] lp:~googol/openlp/i18n into lp:openlp

2011-06-27 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/i18n/+merge/65902 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~googol/openlp/theme into lp:openlp

2011-06-27 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/theme/+merge/65913 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Merge] lp:~googol/openlp/i18n into lp:openlp

2011-06-27 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/i18n into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol/openlp/i18n/+merge/65902 -- https://code.launchpad.net/~googol/openlp/i18n/+merge/65902 Your team OpenLP Core is subscribed

[Openlp-core] [Merge] lp:~googol/openlp/theme into lp:openlp

2011-06-27 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/theme into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol/openlp/theme/+merge/65913 -- https://code.launchpad.net/~googol/openlp/theme/+merge/65913 Your team OpenLP Core is

[Openlp-core] [Bug 648472] Re: Jpegs can't be used as backgrounds in MacOS

2011-06-27 Thread Andreas Preikschat
Re open the bug, so that it is visible on the list again. See also http://support.openlp.org/issues/213 ** Changed in: openlp Status: Fix Released = In Progress ** Changed in: openlp Milestone: 1.9.6 = None -- You received this bug notification because you are a member of OpenLP

[Openlp-core] [Bug 791050] Re: Mac OS: Blank screen button options unavailable when item loaded to Live

2011-06-27 Thread Aaron Rathjen
Preliminary poking around on the Beta 2 release (build 1657) seems to have everything working correctly now! Well done folks! -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/791050 Title: Mac OS:

[Openlp-core] [Bug 648472] Re: Jpegs can't be used as backgrounds in MacOS

2011-06-27 Thread Andreas Preikschat
Hm... not sure if I accidenlty set the milestone to none or if it was launchpad... :-) ** Changed in: openlp Milestone: None = 1.9.6 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/648472 Title:

[Openlp-core] [Merge] lp:~googol/openlp/tweaks into lp:openlp

2011-06-27 Thread noreply
The proposal to merge lp:~googol/openlp/tweaks into lp:openlp has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~googol/openlp/tweaks/+merge/65889 -- https://code.launchpad.net/~googol/openlp/tweaks/+merge/65889 Your team OpenLP Core is subscribed

[Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

2011-06-27 Thread noreply
The proposal to merge lp:~googol/openlp/trivial2 into lp:openlp has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial2/+merge/65901 -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/65901 Your team OpenLP Core is

[Openlp-core] [Merge] lp:~googol/openlp/i18n into lp:openlp

2011-06-27 Thread noreply
The proposal to merge lp:~googol/openlp/i18n into lp:openlp has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~googol/openlp/i18n/+merge/65902 -- https://code.launchpad.net/~googol/openlp/i18n/+merge/65902 Your team OpenLP Core is subscribed to

[Openlp-core] [Bug 796440] Re: String errors in OpenLP 1.9.6

2011-06-27 Thread Andreas Preikschat
Comments #8 and #9 are fixed in r1662. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/796440 Title: String errors in OpenLP 1.9.6 Status in OpenLP - Worship Presentation Software: Confirmed Bug

Re: [Openlp-core] [Merge] lp:~googol/openlp/i18n into lp:openlp

2011-06-27 Thread Andreas Preikschat
Things to be done (as a consequence of this proposal): - add a comment on bug #796440 that the strings mentioned in comment #8 and #9 are fixed - file a bug report to update the service print image in the online manual Done -- https://code.launchpad.net/~googol/openlp/i18n/+merge/65902 Your

[Openlp-core] [Bug 802395] [NEW] [Documentation] Service Print Image need to be updated

2011-06-27 Thread Andreas Preikschat
Public bug reported: Hello, In trunk revision r1662 the close button [1] on the Service Print dialog was removed (to have more space for other things, e. g. the drop down list). In addition the description of the close button has to be removed. [2] Thank you in advance [1]

Re: [Openlp-core] [Merge] lp:~trb143/openlp/lock-toolbar into lp:openlp

2011-06-27 Thread Jonathan Corwin
I think bug 765239 should look at being done as part of this. If there is an option to lock panels, users might expect the existing layout to get saved between restarts. -- https://code.launchpad.net/~trb143/openlp/lock-toolbar/+merge/65890 Your team OpenLP Core is subscribed to branch

[Openlp-core] [Bug 802395] Re: [Documentation] Service Print Image need to be updated

2011-06-27 Thread Andreas Preikschat
** Changed in: openlp/documentation Milestone: None = 1.9.7 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/802395 Title: [Documentation] Service Print Image need to be updated Status in OpenLP

[Openlp-core] [Bug 802395] Re: [Documentation] Service Print Image need to be updated

2011-06-27 Thread Wesley Stout
I will take care of that and glad that is gone. I thought it looked a little out of place there :) ** Changed in: openlp/documentation Status: New = Confirmed ** Changed in: openlp/documentation Assignee: (unassigned) = Wesley Stout (wesleystout) -- You received this bug

Re: [Openlp-core] [Merge] lp:~googol/openlp/render into lp:openlp

2011-06-27 Thread Andreas Preikschat
It's either imageManager and themeManager, or image_manager and theme_manager, but not one of each. themeManager and imageManager are correct (both are Qt based classes). -- https://code.launchpad.net/~googol/openlp/render/+merge/65681 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~googol/openlp/image-queue into lp:openlp

2011-06-27 Thread Andreas Preikschat
I changed this. Also we remove the image from the queue when we remove the image form the cache. -- https://code.launchpad.net/~googol/openlp/image-queue/+merge/65892 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~googol/openlp/image-queue into lp:openlp

2011-06-27 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969 Hello, I changed the image manager in two

Re: [Openlp-core] [Merge] lp:~googol/openlp/image-queue into lp:openlp

2011-06-27 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~smpettit/openlp/custom-delete into lp:openlp

2011-06-27 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/custom-delete into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~smpettit/openlp/custom-delete/+merge/65975 Added code to openlp/plugins/custom/lib/customtab.py to allow the user to

[Openlp-core] [Merge] lp:~smpettit/openlp/windows-help into lp:openlp

2011-06-27 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/windows-help into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~smpettit/openlp/windows-help/+merge/65976 Bug #802161 Added code to create a main window menu item to display

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/windows-help into lp:openlp

2011-06-27 Thread Tim Bentley
Should line 9 have a windows condition checker around it? -- https://code.launchpad.net/~smpettit/openlp/windows-help/+merge/65976 Your team OpenLP Core is requested to review the proposed merge of lp:~smpettit/openlp/windows-help into lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~jseagull1/openlp/documentation into lp:openlp

2011-06-27 Thread Wesley Stout
Review: Needs Fixing I think you need to propose merging this into documentations trunk not into openlps :) -- https://code.launchpad.net/~jseagull1/openlp/documentation/+merge/65982 Your team OpenLP Core is requested to review the proposed merge of lp:~jseagull1/openlp/documentation into

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/windows-help into lp:openlp

2011-06-27 Thread Stevan Pettit
Should line 9 have a windows condition checker around it? I thought about that but decided if the file is present use it, if not, don't. That would make the Windows check redundant. Do local help files exist for other installations of OpenLP? --

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/windows-help into lp:openlp

2011-06-27 Thread Jonathan Corwin
Review: Needs Fixing If we were to do it on other platforms, I'm guessing it would be unlikely for it to be a .chm file as this is a Microsoft format file. So I think an operating system check here would be good to avoid an unnecessary file system lookup. Would it be possible to change the

[Openlp-core] [Bug 802161] Re: [windows] Help File should be reachable within OpenLP

2011-06-27 Thread Andreas Preikschat
** Branch linked: lp:~smpettit/openlp/windows-help -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/802161 Title: [windows] Help File should be reachable within OpenLP Status in OpenLP - Worship

Re: [Openlp-core] [Merge] lp:~jseagull1/openlp/documentation into lp:openlp

2011-06-27 Thread Andreas Preikschat
Review: Resubmit John: Just click Resubmit proposal and change the Target Branch. -- https://code.launchpad.net/~jseagull1/openlp/documentation/+merge/65982 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~trb143/openlp/lock-toolbar into lp:openlp

2011-06-27 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/lock-toolbar into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Andreas Preikschat (googol) For more details, see: https://code.launchpad.net/~trb143/openlp/lock-toolbar/+merge/66013 Simple change for the next cycle. Add the

Re: [Openlp-core] [Merge] lp:~googol/openlp/render into lp:openlp

2011-06-27 Thread Tim Bentley
Review: Needs Fixing u'start tag': u'{br}', u'start html': u'br', u'end tag': u'', in displayTags.py was missed! -- https://code.launchpad.net/~googol/openlp/render/+merge/65681 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~trb143/openlp/lock-toolbar into lp:openlp

2011-06-27 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~trb143/openlp/lock-toolbar/+merge/66013 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~googol/openlp/render into lp:openlp

2011-06-27 Thread Andreas Preikschat
u'start tag': u'{br}', u'start html': u'br', u'end tag': u'', in displayTags.py was missed! No, I am not finished yet ;-) -- https://code.launchpad.net/~googol/openlp/render/+merge/65681 Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~trb143/openlp/b1 into lp:openlp

2011-06-27 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/b1 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #774853 in OpenLP: Color formatting tag displays incorrect color https://bugs.launchpad.net/openlp/+bug/774853 Bug #793745 in OpenLP: Drag drop support

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/custom-delete into lp:openlp

2011-06-27 Thread Andreas Preikschat
Review: Needs Information You didn't change anything. Did you forgot to push your changes? -- https://code.launchpad.net/~smpettit/openlp/custom-delete/+merge/65975 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/custom-delete into lp:openlp

2011-06-27 Thread Stevan Pettit
You didn't change anything. Did you forgot to push your changes? I moved the signal to the end of setupUI (where the other signal is located), my revision 1621. This is identical in layout to the songs plugin. -- https://code.launchpad.net/~smpettit/openlp/custom-delete/+merge/65975 Your team

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/custom-delete into lp:openlp

2011-06-27 Thread Andreas Preikschat
Review: Needs Fixing Please remove the setting for this (not every feature needs to have a setting). :-) -- https://code.launchpad.net/~smpettit/openlp/custom-delete/+merge/65975 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Merge] lp:~smpettit/openlp/custom-delete into lp:openlp

2011-06-27 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/custom-delete into lp:openlp. Requested reviews: Tim Bentley (trb143) Andreas Preikschat (googol) For more details, see: https://code.launchpad.net/~smpettit/openlp/custom-delete/+merge/66068 Added code to