Re: [Openlp-core] [Merge] lp:~m2j/openlp/work into lp:openlp

2011-11-24 Thread m2j
Sorry, I missed to adapt a comment. -- https://code.launchpad.net/~m2j/openlp/work/+merge/83350 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net U

[Openlp-core] [Merge] lp:~m2j/openlp/work into lp:openlp

2011-11-24 Thread m2j
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~m2j/openlp/work/+merge/83351 Bug #875286 use VerseType.Other if it is not recogniced during OpenSong import. -- https://code.launchpad.net/~

[Openlp-core] [Merge] lp:~m2j/openlp/work into lp:openlp

2011-11-24 Thread m2j
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~m2j/openlp/work/+merge/83350 Bug #875286 use VerseType.Other if it is not recogniced during OpenSong import. -- https://code.launchpad.net/~

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bugfixing into lp:openlp

2011-11-24 Thread Tim Bentley
Review: Approve Tested on Fedora 16 - we have webkit working again! Text over video with webkit now works fine -- https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/83347 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing li

[Openlp-core] [Merge] lp:~crichter/openlp/bugfixing into lp:openlp

2011-11-24 Thread rimach
rimach has proposed merging lp:~crichter/openlp/bugfixing into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/83347 For newer versions of webkit playing videos doesnt work anymore. (tested with ubuntu

Re: [Openlp-core] [Merge] lp:~m2j/openlp/work into lp:openlp

2011-11-24 Thread m2j
Good idea. To be honest just ATM I can't imagine any case, where you need to have another default value, but your suggestion saves a some lines of code and makes it more descriptive. -- https://code.launchpad.net/~m2j/openlp/work/+merge/82668 Your team OpenLP Core is subscribed to branch lp:open

Re: [Openlp-core] [Merge] lp:~googol/openlp/ticket-330 into lp:openlp

2011-11-24 Thread Raoul Snyman
Review: Approve I don't have an EasyWorship database to test out, but after examining the code, I don't see any problems. I presume that when Jérémie fixed it up he tested it out (he indicated as much in the ticket). -- https://code.launchpad.net/~googol/openlp/ticket-330/+merge/83338 Your team

Re: [Openlp-core] [Merge] lp:~googol/openlp/ticket-330 into lp:openlp

2011-11-24 Thread Tim Bentley
Review: Approve Obviously the original codes was well tested! -- https://code.launchpad.net/~googol/openlp/ticket-330/+merge/83338 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

[Openlp-core] [Merge] lp:~googol/openlp/ticket-330 into lp:openlp

2011-11-24 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/ticket-330 into lp:openlp has been updated. Commit Message changed to: bzr commit -m "fixed method names causing a traceback (ticket 330)" --author "Jérémie Nau " For more details, see: https://code.launchpad.net/~googol/openlp/ticket-330/+merge/83338 --

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/web-remote into lp:openlp

2011-11-24 Thread Andreas Preikschat
The proposal to merge lp:~raoul-snyman/openlp/web-remote into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/web-remote/+merge/82938 -- https://code.launchpad.net/~raoul-snyman/openlp/web-remote/+merge/8293

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/web-remote into lp:openlp

2011-11-24 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/web-remote/+merge/82938 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

[Openlp-core] [Merge] lp:~googol/openlp/ticket-330 into lp:openlp

2011-11-24 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/ticket-330 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/ticket-330/+merge/83338 - applied patch from http://support.openlp.org/issues/330 - not tested! --

Re: [Openlp-core] [Merge] lp:~m2j/openlp/work into lp:openlp

2011-11-24 Thread Raoul Snyman
Instead of using "strict=False", why not use "default=VerseType.Other", which makes the function more useful. -- https://code.launchpad.net/~m2j/openlp/work/+merge/82668 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https:/

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bug-892571 into lp:openlp

2011-11-24 Thread Tim Bentley
Well If I use a mutex it locks up. Without a major (2-3 month) re-write of the code path as it is very long and impacts plugins etc I am not sure what else to try. The code looks up the current selected service item Selects the next one. Flushes the events to add a cursor Adds a servi