Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89006
Changing the Wrap Slide option into a
Right now, if user saves with wrong syntax, he gets the default name. But if he
opens the settings dialog again, it still contains his old service name which
had wrong syntax. So he could fix it. But this can be seen as bug as well.
--
Also user could add %% to insert % mark (or %20 for space). This gives a python
error on console, but it still saves the file.
--
https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/88693
Your team OpenLP Core is subscribed to branch lp:openlp.
mahfiaz has proposed merging lp:~mahfiaz/openlp/bug-904438 into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Related bugs:
Bug #904438 in OpenLP: Prefilled default service name in save dialog
https://bugs.launchpad.net/openlp/+bug/904438
For more details, see:
Why do you are threating remaining % in filenames as invalid? You could just
pass them. This behaviour would be more transparent and gives the user feedback
about the exact location problem (and saves some code).
--
https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/88693
Your team
Ah, and some other small suggestion: Add a comment for translators in line 274:
They may not use any of the reserved characters (just another ascii string as
third parameter for translate()).
--
https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/89010
Your team OpenLP Core is
1. These were considered invalid in openlp/core/ui/filerenamedialog.py
2. It gives to terminal an error, such as:
(python:26626): Gtk-WARNING **: Unable to retrieve the file info for
`file:///home/mattias/T%C3%B6%C3%B6laud/Service%202012-01-21%2011-00%25': Viga
faili
Review: Needs Fixing
Need to update Receiver() class to document the signal
Looks good apart from that.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89006
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
i18n for scripture references.
I've implemented i18n for scripture reference strings.
Translation is
The proposal to merge lp:~m2j/openlp/i18n into lp:openlp has been updated.
Status: Needs review = Work in progress
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
--
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
Your team OpenLP Core is subscribed
Oh, I was wrong about the second point, should have read the warning more
carefully. This warning is shown for any non-existing file and has nothing to
do with this current patch or % character (that one is escaped nicely to %25 as
it should).
--
mahfiaz has proposed merging lp:~mahfiaz/openlp/bug-904438 into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Related bugs:
Bug #904438 in OpenLP: Prefilled default service name in save dialog
https://bugs.launchpad.net/openlp/+bug/904438
For more details, see:
Review: Approve
--
https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/89122
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Meinert Jordan has proposed merging lp:~m2j/openlp/i18n into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/i18n/+merge/89111
i18n for scripture references.
I've implemented i18n for scripture reference strings.
Translation is
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-687638 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
I've splitted a previous merge request. This one contains only ICU integration:
Bug
15 matches
Mail list logo
