[Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-904438 into lp:openlp

2012-01-29 Thread mahfiaz
mahfiaz has proposed merging lp:~mahfiaz/openlp/bug-904438 into lp:openlp. Requested reviews: Tim Bentley (trb143) Andreas Preikschat (googol) Raoul Snyman (raoul-snyman) Related bugs: Bug #904438 in OpenLP: Prefilled default service name in save dialog

Re: [Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-904438 into lp:openlp

2012-01-29 Thread mahfiaz
I didn't deal with the signals. I have no idea, how costly is running strfmtime four times. -- https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/90613 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-904438 into lp:openlp

2012-01-29 Thread Meinert Jordan
The cost of calling it four times is really narrow. While looking to this I asked myself, why you are using self.service_day. You could use unicode(self.defaultServiceName.text()) each time. Then you could call self.updateServiceNameExample on the slot and save several lines of code. This two

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/getAndroid into lp:openlp

2012-01-29 Thread Tim Bentley
Review: Needs Fixing Looked at the diff and the resources.py file looks corrupt. You seem to have deleted the xml for songs icons. -- https://code.launchpad.net/~phill-ridout/openlp/getAndroid/+merge/90607 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~staffj01/openlp/slideadvance into lp:openlp

2012-01-29 Thread Raoul Snyman
Looks good, but I want to play with it before I approve it. -- https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90571 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to

Re: [Openlp-core] [Merge] lp:~m2j/openlp/i18n into lp:openlp

2012-01-29 Thread Raoul Snyman
Review: Approve This looks fine to me, but being linguistically-challenged, I can't test it out properly. Maybe we can get Andreas to do that? -- https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-910860 into lp:openlp

2012-01-29 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-910860/+merge/90577 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~staffj01/openlp/slideadvance into lp:openlp

2012-01-29 Thread Tim Bentley
Review: Needs Fixing Works fine 361 u'last slide' u is missing -- https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90571 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core

Re: [Openlp-core] [Merge] lp:~m2j/openlp/i18n into lp:openlp

2012-01-29 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~m2j/openlp/i18n/+merge/89545 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/getAndroid into lp:openlp

2012-01-29 Thread Tim Bentley
Review: Needs Fixing When I selected the Remote Tab the Settings dialog increased by 1/3 to fit in the text. Need to keep a constant size -- https://code.launchpad.net/~phill-ridout/openlp/getAndroid/+merge/90619 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-910860 into lp:openlp

2012-01-29 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-910860/+merge/90577 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Bug 923496] [NEW] Traceback when closing main window before the service is loaded

2012-01-29 Thread mahfiaz
Public bug reported: 1. Have OpenLP open the lastly used service on load. 2. Close the main window before the service actually get's loaded. I suspect this works as well when opening a service file by hand and closing the window before it loads. Traceback (most recent call last): File

Re: [Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-904438 into lp:openlp

2012-01-29 Thread Tim Bentley
Review: Needs Fixing Set the option to use the default but forget to generate the format does not give an error message nor does it use a default. You have to remember to press the generate default button -- https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/90613 Your team OpenLP

[Openlp-core] [Bug 923500] [NEW] Service marked as changed when saving settings

2012-01-29 Thread mahfiaz
Public bug reported: Close OpenLP settings dialog with OK. Service is marked as changed and asks if you want to save it, when you close the program. ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenLP Core,

[Openlp-core] [Bug 923498] [NEW] Stage view clock height

2012-01-29 Thread mahfiaz
Public bug reported: OpenLP stage view: Verse indicator and clock are not the same height. If text runs to the clock, it is wrapped to next line. If you don't have that long lines, use Ctrl + to make text bigger. ** Affects: openlp Importance: Undecided Status: New -- You

[Openlp-core] [Bug 923502] [NEW] Drag song or any other element to preview or live area

2012-01-29 Thread mahfiaz
Public bug reported: If would be neat, if dragging songs from title or specific verse, image or any other item either from plugin's list of items or service manager list to preview or live area started preview or sent the item to live. ** Affects: openlp Importance: Undecided

[Openlp-core] [Bug 923504] [NEW] Verse markers get updated only once on Ubuntu 12.04

2012-01-29 Thread mahfiaz
Public bug reported: This might be as well Qt bug, or even someone else's, haven't seen this before, therefore most likely is caused by updated libraries or nasty hacks in Ubuntu 12.04. 1. Preview a song. 2. Preview another one. 3. See how verse tag on the left of lyrics are not updated. **

[Openlp-core] [Bug 923502] Re: Drag song or any other element to preview or live area

2012-01-29 Thread Tim Bentley
** Changed in: openlp Importance: Undecided = Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/923502 Title: Drag song or any other element to preview or live area Status in OpenLP -

[Openlp-core] [Bug 923504] Re: Verse markers get updated only once on Ubuntu 12.04

2012-01-29 Thread Tim Bentley
Qt or PYQT bug. It arrived in Fedora 16. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/923504 Title: Verse markers get updated only once on Ubuntu 12.04 Status in OpenLP - Worship Presentation

[Openlp-core] [Bug 918718] Re: overridden mispelled

2012-01-29 Thread Meinert Jordan
this applies also to plugins/presentations/lib/presentationstab.py and core/ui/media/mediacontroller -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/918718 Title: overridden mispelled Status in

[Openlp-core] [Merge] lp:~staffj01/openlp/slideadvance into lp:openlp

2012-01-29 Thread Jonathan Stafford
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90623 Changing the Wrap Slide option into a

[Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-904438 into lp:openlp

2012-01-29 Thread mahfiaz
mahfiaz has proposed merging lp:~mahfiaz/openlp/bug-904438 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Andreas Preikschat (googol) Related bugs: Bug #904438 in OpenLP: Prefilled default service name in save dialog

[Openlp-core] [Bug 917421] Re: Missing %s in translation results in an traceback and may make some parts of the program unusable

2012-01-29 Thread Meinert Jordan
Pootle listed such errors. I've just tried Transifex and it did not accept a wrong string. AFAIK Linguist prints a warning and will mark the value (even though it will be accepted). Translators will be always able to break OpenLP, but I think with the current situation they have to do it on

Re: [Openlp-core] [Merge] lp:~staffj01/openlp/slideadvance into lp:openlp

2012-01-29 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/90623 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-904438 into lp:openlp

2012-01-29 Thread Tim Bentley
Review: Needs Fixing Camel police time. There are inconsistencies in the class now. Python classes allow service_name structures QT based classes need serviceName This is a QT based class so needs fixing. lines 15 and 16 are inconsistent. --