[Openlp-core] [Bug 927585] Re: Gracefully handle cases where the user closes the presentation application

2012-03-10 Thread phill
I have seen this a few times on the support tracker. It happens when the user closes PPT & Impress, and then tries to do something that requires it, such as add a presentation (need for thumbnail generation) Displaying a presentation. I have seen reports from when OpenLP exits and tries to close

[Openlp-core] [Bug 918718] Re: overridden mispelled

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Status: Fix Committed => Fix Released ** Changed in: openlp Milestone: None => 1.9.9 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/918718 Title: overridden mispelle

[Openlp-core] [Bug 943380] Re: wrapping slides typo

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Status: Fix Committed => Fix Released ** Changed in: openlp Milestone: None => 1.9.9 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/943380 Title: wrapping slides typ

Re: [Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-903683 into lp:openlp

2012-03-10 Thread Jonathan Corwin
Note, I fixed the overridden spelling in a different branch, so you'll need to update with trunk too. -- https://code.launchpad.net/~mahfiaz/openlp/bug-903683/+merge/96713 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https

[Openlp-core] [Bug 936236] Re: Up/Down icons needed in media settings tab

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Status: In Progress => Fix Released ** Changed in: openlp Milestone: None => 1.9.9 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/936236 Title: Up/Down icons needed

[Openlp-core] [Bug 943919] Re: Shortcut for Move to Previous/Next is not configurable in shortcut dialog

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/943919 Title: Shortcut for Move to Previous/Next is not configurable in shortcut di

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/display_overide into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/display_overide/+merge/96903 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Merge] lp:~phill-ridout/openlp/display_overide into lp:openlp

2012-03-10 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/display_overide into lp:openlp. Requested reviews: Tim Bentley (trb143) Jonathan Corwin (j-corwin) Raoul Snyman (raoul-snyman) Related bugs: Bug #883056 in OpenLP: "Monitor selection drop down list should be disabled when "Override displ

[Openlp-core] [Merge] lp:~j-corwin/openlp/typos into lp:openlp

2012-03-10 Thread noreply
The proposal to merge lp:~j-corwin/openlp/typos into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~j-corwin/openlp/typos/+merge/96891 -- https://code.launchpad.net/~j-corwin/openlp/typos/+merge/96891 Your team OpenLP Core is sub

[Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-304 into lp:openlp

2012-03-10 Thread noreply
The proposal to merge lp:~mahfiaz/openlp/bug-304 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~mahfiaz/openlp/bug-304/+merge/96714 -- https://code.launchpad.net/~mahfiaz/openlp/bug-304/+merge/96714 Your team OpenLP Core is sub

[Openlp-core] [Merge] lp:~crichter/openlp/bug-936236 into lp:openlp

2012-03-10 Thread noreply
The proposal to merge lp:~crichter/openlp/bug-936236 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~crichter/openlp/bug-936236/+merge/96674 -- https://code.launchpad.net/~crichter/openlp/bug-936236/+merge/96674 Your team OpenLP

[Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-03-10 Thread noreply
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225 -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225 Your team OpenLP Core is subscribed to

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/overwrite/+merge/96901 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsub

[Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/overwrite into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Jonathan Corwin (j-corwin) Related bugs: Bug #904928 in OpenLP: "Warning on overwriting existing theme" https://bugs.launchpad.net/openlp/+bug/

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/typos into lp:openlp

2012-03-10 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~j-corwin/openlp/typos/+merge/96891 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/display_overide into lp:openlp

2012-03-10 Thread Raoul Snyman
Found out how to fix it. Right under the "SettingsTab.setupUi(self)" put the following line: self.tabLayout.setStretch(1, 1) -- https://code.launchpad.net/~phill-ridout/openlp/display_overide/+merge/96840 Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~phill-ridout/openlp/display_overide into lp:openlp

2012-03-10 Thread Raoul Snyman
The proposal to merge lp:~phill-ridout/openlp/display_overide into lp:openlp has been updated. Status: Rejected => Needs review For more details, see: https://code.launchpad.net/~phill-ridout/openlp/display_overide/+merge/96840 -- https://code.launchpad.net/~phill-ridout/openlp/display_over

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/typos into lp:openlp

2012-03-10 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~j-corwin/openlp/typos/+merge/96891 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Merge] lp:~phill-ridout/openlp/display_overide into lp:openlp

2012-03-10 Thread Raoul Snyman
The proposal to merge lp:~phill-ridout/openlp/display_overide into lp:openlp has been updated. Status: Approved => Rejected For more details, see: https://code.launchpad.net/~phill-ridout/openlp/display_overide/+merge/96840 -- https://code.launchpad.net/~phill-ridout/openlp/display_overide/

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/display_overide into lp:openlp

2012-03-10 Thread Raoul Snyman
Review: Needs Fixing Maybe it's just me, but there's now a huge margin around all the group boxes that doesn't exist on the other pages... -- https://code.launchpad.net/~phill-ridout/openlp/display_overide/+merge/96840 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Approve OK. I guess we should try and fix those Bibles at some point assuming we have someone who can speak the right language! -- https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/96893 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

2012-03-10 Thread Armin Köhler
Armin Köhler has proposed merging lp:~orangeshirt/openlp/bibles into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Jonathan Corwin (j-corwin) Related bugs: Bug #822363 in OpenLP: "[i18n] OSIS Bible Book Names are always in English" https://bugs.launchpad.net/openlp/+bug/822363

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

2012-03-10 Thread Armin Köhler
> I just tried this, I got the branch and ran it (In default language, since I > don't know how to get a different language when running from a branch). I went > into the settings and set to use the Bible language. > I brought up the first time wizard and downloaded some non English Bibles. > > Th

[Openlp-core] [Bug 943380] Re: wrapping slides typo

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Assignee: (unassigned) => Jonathan Corwin (j-corwin) ** Branch linked: lp:~j-corwin/openlp/typos ** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenL

[Openlp-core] [Bug 918718] Re: overridden mispelled

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Assignee: (unassigned) => Jonathan Corwin (j-corwin) ** Branch linked: lp:~j-corwin/openlp/typos ** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenL

[Openlp-core] [Merge] lp:~j-corwin/openlp/typos into lp:openlp

2012-03-10 Thread Jonathan Corwin
Jonathan Corwin has proposed merging lp:~j-corwin/openlp/typos into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #918718 in OpenLP: "overridden mispelled" https://bugs.launchpad.net/openlp/+bug/918718 Bug #943380 in OpenLP: "wrapping slides typo" https://bugs

[Openlp-core] [Bug 820431] Re: unit tests for importing songs from other formats

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Importance: Low => Wishlist -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/820431 Title: unit tests for importing songs from other formats Status in OpenLP - Worship Present

[Openlp-core] [Bug 929825] Re: CCLI songselect beta change

2012-03-10 Thread Jonathan Corwin
I notice that the old format has a (c) symbol at the beginning of the copyright line, but the new format doesn't. Do you know if all songs in the old format always begin with this symbol, so we can use it to distinguish? Failing that, is there anything else in the file that gives a clue as to the

[Openlp-core] [Bug 883056] Re: Monitor selection drop down list should be disabled when "Override display postition" is checked

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/883056 Title: Monitor selection drop down list should be disabled when "Override displ

[Openlp-core] [Bug 904928] Re: Warning on overwriting existing theme

2012-03-10 Thread Jonathan Corwin
** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/904928 Title: Warning on overwriting existing theme Status in OpenLP - Worship Presenta

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Needs Fixing Sorry found another: Traceback (most recent call last): File "C:\Users\Jonathan\Documents\projects\openlp\overwrite\openlp\core\ui\themeform.py", line 253, in onCustom1ButtonClicked width = self.thememanager.mainwindow.renderer.width AttributeError: 'ThemeManager' obj

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Needs Fixing Gave it permission to overwrite a theme and got: Traceback (most recent call last): File "C:\Users\Jonathan\Documents\projects\openlp\overwrite\openlp\core\ui\thememanager.py", line 431, in onImportTheme self.unzipTheme(file, self.path) File "C:\Users\Jonathan\Docu

[Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-03-10 Thread Tim Bentley
The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225 -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225 Your team OpenLP Core is subscri

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-03-10 Thread Tim Bentley
Review: Approve Approved and Jonathan has confirmed Windows is not impacted which was my worry. -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/96225 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad

[Openlp-core] [Bug 951618] [NEW] 'File not found' error when importing large number of files

2012-03-10 Thread phill
Public bug reported: 'File not found' error when adding a large number of files to a list widget on the song importer. Appears to be a platform specific bug on Windows XP http://openlp.org/en/forums/troubleshooting/openlporg-problems/importing-words-of-worship-songs-error http://support.openlp.o

[Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/overwrite into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Jonathan Corwin (j-corwin) Related bugs: Bug #904928 in OpenLP: "Warning on overwriting existing theme" https://bugs.launchpad.net/openlp/+bug/

[Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/overwrite into lp:openlp. Requested reviews: Tim Bentley (trb143) Jonathan Corwin (j-corwin) Raoul Snyman (raoul-snyman) Related bugs: Bug #904928 in OpenLP: "Warning on overwriting existing theme" https://bugs.launchpad.net/openlp/+bug/

[Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/overwrite into lp:openlp. Requested reviews: Tim Bentley (trb143) Raoul Snyman (raoul-snyman) Jonathan Corwin (j-corwin) Related bugs: Bug #904928 in OpenLP: "Warning on overwriting existing theme" https://bugs.launchpad.net/openlp/+bug/

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

2012-03-10 Thread Jonathan Corwin
I have now seen it working with a Web Bible I downloaded. Does this mean that the first time wizard Bibles are missing some information? -- https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/96437 Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-304 into lp:openlp

2012-03-10 Thread Jonathan Corwin
The proposal to merge lp:~mahfiaz/openlp/bug-304 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~mahfiaz/openlp/bug-304/+merge/96714 -- https://code.launchpad.net/~mahfiaz/openlp/bug-304/+merge/96714 Your team OpenLP Core

[Openlp-core] [Merge] lp:~crichter/openlp/bug-936236 into lp:openlp

2012-03-10 Thread Jonathan Corwin
The proposal to merge lp:~crichter/openlp/bug-936236 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~crichter/openlp/bug-936236/+merge/96674 -- https://code.launchpad.net/~crichter/openlp/bug-936236/+merge/96674 Your team

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

2012-03-10 Thread Jonathan Corwin
Oh I should have changed this on 309 also: Openlp -> OpenLP -- https://code.launchpad.net/~orangeshirt/openlp/bibles/+merge/96437 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Needs Fixing Lines 45-128 should have a space after the comma. Line 396: Spaces either side of the +'s 294-297, change to: 294 + self.languageSelectionLabel.setText(translate('BiblesPlugin.BiblesTab', 295 +'Choose the language in which the book names of the\nBi

[Openlp-core] [Bug 936281] Re: Distinguish between "displayed" and "not displayed" service items

2012-03-10 Thread Jonathan Corwin
OK, that is fine, as long as the currently displayed item is highlighted differently. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/936281 Title: Distinguish between "displayed" and "not displayed"

Re: [Openlp-core] [Bug 936281] Re: Distinguish between "displayed" and "not displayed" service items

2012-03-10 Thread Andreas Preikschat
: > I'm not sure marking items as Unviewed would help... we go through the > songs before the service so they would all be marked as done, and if we > hop around a bit or show the wrong song by mistake it could get > confusing. For that case we could have this green button/icon/overlay (like in th

Re: [Openlp-core] [Merge] lp:~mahfiaz/openlp/bug-304 into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~mahfiaz/openlp/bug-304/+merge/96714 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-03-10 Thread Jonathan Corwin
Tim, do you mean these type of lines? 619 -filename = unicode(QtCore.QDir.toNativeSeparators(filename)) 620 +filename = unicode(filename).replace(u'/', os.path.sep) I don't think the functionality has changed, just the method used for consistency with other code.

[Openlp-core] [Merge] lp:~phill-ridout/openlp/display_overide into lp:openlp

2012-03-10 Thread Tim Bentley
The proposal to merge lp:~phill-ridout/openlp/display_overide into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~phill-ridout/openlp/display_overide/+merge/96840 -- https://code.launchpad.net/~phill-ridout/openlp/display_over

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/display_overide into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/display_overide/+merge/96840 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread Jonathan Corwin
Review: Needs Fixing real_theme_name rather than realtheme_name old_theme_name rather than oldtheme_name 161: Remove the exclamation!, it's not that exciting that it already exists ;-) 164: Remove the leading "The", so it starts: Theme %s ... 287: You've got two spaces after each comma instead of

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread Tim Bentley
Review: Needs Fixing unzipVersion122 returns abort_import always a false. It would be better to not change that API. Default abort_import to false and only set it to true if necessary. -- https://code.launchpad.net/~phill-ridout/openlp/overwrite/+merge/96872 Your team OpenLP Core is subscribed

[Openlp-core] [Bug 904928] Re: Warning on overwriting existing theme

2012-03-10 Thread phill
** Branch linked: lp:~phill-ridout/openlp/overwrite -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/904928 Title: Warning on overwriting existing theme Status in OpenLP - Worship Presentation Softwar

[Openlp-core] [Merge] lp:~phill-ridout/openlp/overwrite into lp:openlp

2012-03-10 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/overwrite into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Related bugs: Bug #904928 in OpenLP: "Warning on overwriting existing theme" https://bugs.launchpad.net/openlp/+bug/904928 For more details, see: https://code.launchpa