Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-953240 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-953240/+merge/100517 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-953240 into lp:openlp

2012-04-02 Thread Meinert Jordan
Yes. It should. It crops the additional data, and in case there are multiple subverses, they are merged with a [---] separator in between. -- https://code.launchpad.net/~m2j/openlp/bug-953240/+merge/100517 Your team OpenLP Core is requested to review the proposed merge of lp:~m2j/openlp/bug-9532

[Openlp-core] [Bug 923504] Re: Verse markers get updated only once with QT 4.8

2012-04-02 Thread Joe Mulloy
Still occurring on openSUSE Factory (12.2) with QT 4.8.1. Anyone know what library fixed this? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/923504 Title: Verse markers get updated only once with QT

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Resubmit Changing this to a "Please Resubmit" to just remind us all that the other proposals should be merged before this one, and then trunk HEAD should be merged in, and the proposal resubmitted. -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100501 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100518 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-953240 into lp:openlp

2012-04-02 Thread phill
Does this fix the issue surrounding verse tags such as "v1.5" and "v2_alternative" On Apr 2, 2012 9:57 PM, "Meinert Jordan" wrote: > Meinert Jordan has proposed merging lp:~m2j/openlp/bug-953240 into > lp:openlp. > > Requested reviews: > OpenLP Core (openlp-core) > > For more details, see: > htt

[Openlp-core] [Bug 967522] Re: HIghlighted item in service will move if dragging a blank area

2012-04-02 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/967522 Title: HIghlighted item in service will move if dragging a blank area Status in OpenLP - Worship Presentation Softwa

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-969282 into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-969282/+merge/100520 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Bug 923500] Re: Service marked as changed when saving settings

2012-04-02 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/923500 Title: Service marked as changed when saving settings Status in OpenLP - Worship Presentation Software: Fix Commit

[Openlp-core] [Bug 959760] Re: Changing default theme does not change theme manager tool buttons

2012-04-02 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/959760 Title: Changing default theme does not change theme manager tool buttons Status in OpenLP - Worship Presentation Sof

[Openlp-core] [Merge] lp:~m2j/openlp/bug-967522 into lp:openlp

2012-04-02 Thread noreply
The proposal to merge lp:~m2j/openlp/bug-967522 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~m2j/openlp/bug-967522/+merge/100399 -- https://code.launchpad.net/~m2j/openlp/bug-967522/+merge/100399 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~m2j/openlp/bug-795068 into lp:openlp

2012-04-02 Thread noreply
The proposal to merge lp:~m2j/openlp/bug-795068 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~m2j/openlp/bug-795068/+merge/100409 -- https://code.launchpad.net/~m2j/openlp/bug-795068/+merge/100409 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~m2j/openlp/bug-969282 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-969282 into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-969282/+merge/100520 Bug #969282: Remove control characters from song copyright string -- https://code.launch

[Openlp-core] [Merge] lp:~m2j/openlp/bug-959760 into lp:openlp

2012-04-02 Thread noreply
The proposal to merge lp:~m2j/openlp/bug-959760 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~m2j/openlp/bug-959760/+merge/100414 -- https://code.launchpad.net/~m2j/openlp/bug-959760/+merge/100414 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~m2j/openlp/bug-923500 into lp:openlp

2012-04-02 Thread noreply
The proposal to merge lp:~m2j/openlp/bug-923500 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~m2j/openlp/bug-923500/+merge/100452 -- https://code.launchpad.net/~m2j/openlp/bug-923500/+merge/100452 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/songs into lp:openlp

2012-04-02 Thread noreply
The proposal to merge lp:~googol/openlp/songs into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/songs/+merge/100490 -- https://code.launchpad.net/~googol/openlp/songs/+merge/100490 Your team OpenLP Core is subscribed

[Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-960386 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100518 Bug #960386: string fixes fix missalignment of theme level

[Openlp-core] [Bug 953240] Re: OpenSong importer crashes at v1a verse markup

2012-04-02 Thread Meinert Jordan
** Changed in: openlp Assignee: (unassigned) => Meinert Jordan (m2j) ** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/953240 Title:

[Openlp-core] [Merge] lp:~m2j/openlp/bug-953240 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-953240 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-953240/+merge/100517 Bug #953240: Merging subverse entries (e.g. v1a) at OpenSong import -- https://code

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve Make sure you merge HEAD from trunk after all the other fixes go in. -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100501 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~open

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Needs Fixing Sorry, rather than deleting this, change line 294 in slidecontroller.py to use this. 8 - self.NextTrack = translate('OpenLP.Ui', 'Next Track') -- https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100504 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-967522 into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-967522/+merge/100399 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~m2j/openlp/bug-967522 into lp:openlp

2012-04-02 Thread Raoul Snyman
The proposal to merge lp:~m2j/openlp/bug-967522 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~m2j/openlp/bug-967522/+merge/100399 -- https://code.launchpad.net/~m2j/openlp/bug-967522/+merge/100399 Your team OpenLP Core is

[Openlp-core] [Merge] lp:~m2j/openlp/bug-795068 into lp:openlp

2012-04-02 Thread Raoul Snyman
The proposal to merge lp:~m2j/openlp/bug-795068 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~m2j/openlp/bug-795068/+merge/100409 -- https://code.launchpad.net/~m2j/openlp/bug-795068/+merge/100409 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-795068 into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-795068/+merge/100409 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~m2j/openlp/bug-959760 into lp:openlp

2012-04-02 Thread Raoul Snyman
The proposal to merge lp:~m2j/openlp/bug-959760 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~m2j/openlp/bug-959760/+merge/100414 -- https://code.launchpad.net/~m2j/openlp/bug-959760/+merge/100414 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-959760 into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-959760/+merge/100414 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-959116 into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve That looks good, but it might be a good idea to refactor that insertSingleLineTextAtCursor into a slightly more generic function that can take a QTextEdit and text and insert the text into the QTextEdit. -- https://code.launchpad.net/~m2j/openlp/bug-959116/+merge/100422 Your tea

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-923500 into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-923500/+merge/100452 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~m2j/openlp/bug-923500 into lp:openlp

2012-04-02 Thread Raoul Snyman
The proposal to merge lp:~m2j/openlp/bug-923500 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~m2j/openlp/bug-923500/+merge/100452 -- https://code.launchpad.net/~m2j/openlp/bug-923500/+merge/100452 Your team OpenLP Core is

[Openlp-core] [Merge] lp:~googol/openlp/songs into lp:openlp

2012-04-02 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/songs into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/songs/+merge/100490 -- https://code.launchpad.net/~googol/openlp/songs/+merge/100490 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-960386 into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100504 Bug #960386: string fixes fix missalignment of theme level selection labels change defaul

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/DreamBeam into lp:openlp

2012-04-02 Thread phill
> > > Where did you get the version 0.49 from? > > > > > I downloaded the dreamBeam source and I imported the files from > DreamBeam-0.81/Installer/SampleFiles/Songs. Ahh yes, those files, they were in the sample files that the user supplied, but they were only 2 of over 800! -- https://code.la

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve Approved -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100501 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubs

Re: [Openlp-core] [Merge] lp:~googol/openlp/songs into lp:openlp

2012-04-02 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/songs/+merge/100490 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Meinert Jordan
Sorry missed the "missing" one. Will apply all three changes -- https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100500 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : o

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Needs Fixing 68 - Keep Slide ==> Remain on Slide 80 - arround => around 201 -need to add work "missing" Import is not clear, does it overwrite? If playing with text then the Left hand side is a bit wide and jumps the first time you enter the slide. -- https://code.launchpad.net/~m2j/op

[Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-960386 into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100500 Bug #960386: string fixes fix missalignment of theme level selection labels change defaul

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Needs Fixing 248 need a space increate_push_button 2029 OnItemTriggered should be OnItemActivated -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/100350 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https

Re: [Openlp-core] [Merge] lp:~googol/openlp/songs into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/songs/+merge/100490 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-969282 into lp:openlp

2012-04-02 Thread Andreas Preikschat
https://code.launchpad.net/~googol/openlp/songs/+merge/100490 -- https://code.launchpad.net/~m2j/openlp/bug-969282/+merge/100395 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-969282 into lp:openlp

2012-04-02 Thread Andreas Preikschat
> Fix looks ok but the setText to Clear are they necessary? Hm... I just proposed for merging. We will end up with a conflict. I changed the lines to: self.blaFooCombo.setText(self.song.title if self.song.title else u'') -- https://code.launchpad.net/~m2j/openlp/bug-969282/+merge/100395 Your te

Re: [Openlp-core] [Merge] lp:~googol/openlp/bibles into lp:openlp

2012-04-02 Thread Andreas Preikschat
> This would be another option (I prefere): > line 39: tmp_bibles = filter(None, bibles) Yeah, that's a good point :-) I am going to fix this... -- https://code.launchpad.net/~googol/openlp/bibles/+merge/100333 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~googol/openlp/songs into lp:openlp

2012-04-02 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/songs into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/songs/+merge/100490 Hello, Just a few trivial clean ups -- https://code.launchpad.net/~googol/openlp/s

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-923500 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve Nice one -- https://code.launchpad.net/~m2j/openlp/bug-923500/+merge/100452 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-959116 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-959116/+merge/100422 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-959760 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-959760/+merge/100414 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-795068 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~m2j/openlp/bug-795068/+merge/100409 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-967522 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve nice one -- https://code.launchpad.net/~m2j/openlp/bug-967522/+merge/100399 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-969282 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Approve Fix looks ok but the setText to Clear are they necessary? -- https://code.launchpad.net/~m2j/openlp/bug-969282/+merge/100395 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core P

[Openlp-core] [Bug 917164] Re: Bible upgrade wizard - not localized language list

2012-04-02 Thread Meinert Jordan
So we have add some code to the translation_utils.py script, which extracts the strings from bibles_resources.sqlite and feed them into the *.ts file. So they can be translated. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://b

[Openlp-core] [Bug 923500] Re: Service marked as changed when saving settings

2012-04-02 Thread Meinert Jordan
** Changed in: openlp Assignee: (unassigned) => Meinert Jordan (m2j) ** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/923500 Title:

[Openlp-core] [Merge] lp:~m2j/openlp/bug-923500 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-923500 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-923500/+merge/100452 Bug #923500: Do not mark service changed when accepting settings dialog. -- https:/

[Openlp-core] [Bug 959116] Re: Split slide button should insert tag on its own line

2012-04-02 Thread Meinert Jordan
** Changed in: openlp Assignee: (unassigned) => Meinert Jordan (m2j) ** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/959116 Title:

[Openlp-core] [Merge] lp:~m2j/openlp/bug-959116 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-959116 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-959116/+merge/100422 Bug #959116: Split slide button inserts tag on its own line -- https://code.launchp

[Openlp-core] [Merge] lp:~m2j/openlp/bug-959760 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-959760 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-959760/+merge/100414 Bug #959760: Change theme manager delete button visibility on default theme change.

[Openlp-core] [Bug 959760] Re: Changing default theme does not change theme manager tool buttons

2012-04-02 Thread Meinert Jordan
** Changed in: openlp Assignee: (unassigned) => Meinert Jordan (m2j) ** Changed in: openlp Status: New => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/959760 Title: Chang

[Openlp-core] [Merge] lp:~m2j/openlp/bug-795068 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-795068 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-795068/+merge/100409 Bug #795068: Verse List in Song Editor did not resize properly -- https://code.laun

[Openlp-core] [Bug 795068] Re: Verse List in Song Editor does not resize properly

2012-04-02 Thread Meinert Jordan
** Changed in: openlp Assignee: Raoul Snyman (raoul-snyman) => Meinert Jordan (m2j) ** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs

[Openlp-core] [Bug 967522] Re: HIghlighted item in service will move if dragging a blank area

2012-04-02 Thread Meinert Jordan
** Changed in: openlp Assignee: (unassigned) => Meinert Jordan (m2j) ** Changed in: openlp Importance: Undecided => Low ** Changed in: openlp Status: New => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Merge] lp:~m2j/openlp/bug-967522 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-967522 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-967522/+merge/100399 Bug #967522: Don't drag from empty service manager area -- https://code.launchpad.n

[Openlp-core] [Bug 969282] Re: Title, copyright and author are not shown

2012-04-02 Thread Meinert Jordan
** Changed in: openlp Assignee: (unassigned) => Meinert Jordan (m2j) ** Changed in: openlp Status: New => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/969282 Title: Title

[Openlp-core] [Merge] lp:~m2j/openlp/bug-969282 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-969282 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-969282/+merge/100395 Bug #969282: Remove control characters from song copyright string -- https://code.l

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Meinert Jordan
Lines 62-63: For me the sentence makes complete sense. Other than that some native speaker has to suggest some other string, as the problem seems to be my limites in English grammar. -- https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100383 Your team OpenLP Core is subscribed to branch

Re: [Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Tim Bentley
Review: Needs Fixing 62-63 does not make sense. 202 - need to add work "missing" Import is not clear, does it overwrite? -- https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100383 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mai

[Openlp-core] [Bug 960386] Re: String fixes after 1.9.9 release

2012-04-02 Thread Meinert Jordan
** Changed in: openlp Status: New => Fix Committed ** Changed in: openlp Assignee: (unassigned) => Meinert Jordan (m2j) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/960386 Title: Strin

[Openlp-core] [Merge] lp:~m2j/openlp/bug-960386 into lp:openlp

2012-04-02 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/bug-960386 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/bug-960386/+merge/100383 Bug #960386: string fixes fix missalignment of theme level selection labels change d

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/DreamBeam into lp:openlp

2012-04-02 Thread Meinert Jordan
Just had a short look to the sources: The version differences for the current formats are well documented in FileTypes/Song.cs:905-929. There is a older format until v0.5 which is handled via FileTypes/SongOld.cs. As they do not just handle this in the current file, I expect it to have major dif

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

2012-04-02 Thread Meinert Jordan
As I said: No features added, no functional change. Using the wrong button signal can be rated as bug, but I don't want to argue about it, as there is no point to argue about the categorisation. For usual releases such changes are permitted until the very end of the merge window. -- https://co