Re: [Openlp-core] [Merge] lp:~trb143/openlp/remotes into lp:openlp

2012-04-16 Thread Tim Bentley
I was following line 38 ! -- https://code.launchpad.net/~trb143/openlp/remotes/+merge/102150 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/web-remote into lp:openlp

2012-04-16 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/web-remote/+merge/102194 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Uns

Re: [Openlp-core] [Merge] lp:~trb143/openlp/remotes into lp:openlp

2012-04-16 Thread Jonathan Corwin
Review: Needs Information What is the "or 0" for on line 37? Since it's initialised to 0 on line 8, is it necessary? -- https://code.launchpad.net/~trb143/openlp/remotes/+merge/102150 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailin

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

2012-04-16 Thread Jonathan Corwin
Changes are fine, but just wondering if there should be a "if not remote:" prior to line 138 as per 125? -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/102059 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: htt

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-16 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102027 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~trb143/openlp/remotes into lp:openlp

2012-04-16 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/remotes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp/remotes/+merge/102150 Add tag to allow the Android client to see if a service list has changed since it's la

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

2012-04-16 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/102059 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

2012-04-16 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial2 into lp:openlp has been updated. Description changed to: Hello, - trivial clean ups Note: In the lines 62-143 I moved the for loop out of the if. For more details, see: https://code.launchpad.net/~googol/openlp/trivial2/+merge/102059 -- https: