Re: [Openlp-core] [Merge] lp:~sfindlay/openlp/songs-import-powersong into lp:openlp

> If all you're doing is ensuring that your import source is a list, you might want to negate that if statement, and exit immediately. Good idea. -- https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104254 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/data-path into lp:openlp

Review: Needs Fixing 126 + 'Warning - New data directory location contains OpenLP ' 127 + 'data files. These files WILL be replaced during a copy.')) I recommend making that "Warning" all upper case, and using a colon instead of a dash: "WARNING: ..." 140 + 'Data directory err

[Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

The proposal to merge lp:~googol/openlp/trivial2 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial2/+merge/104234 -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/104234 Your team OpenLP Core is s

Re: [Openlp-core] [Merge] lp:~sfindlay/openlp/songs-import-powersong into lp:openlp

249 + if isinstance(self.importSource, list): If all you're doing is ensuring that your import source is a list, you might want to negate that if statement, and exit immediately. That way you don't need to have the rest of the code in the method indented one more level. Gives you four extra

[Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

The proposal to merge lp:~googol/openlp/trivial2 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial2/+merge/104234 -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/104234 Your team OpenLP Cor

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/104234 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~smpettit/openlp/data-path into lp:openlp

Stevan Pettit has proposed merging lp:~smpettit/openlp/data-path into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~smpettit/openlp/data-path/+merge/104288 Take 2 of User Specified Data Location. Last needs fixing comment: The sett

[Openlp-core] [Merge] lp:~sfindlay/openlp/songs-import-powersong into lp:openlp

Samuel Findlay has proposed merging lp:~sfindlay/openlp/songs-import-powersong into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104254 Superseded proposal: * As per some of Phill's s

Re: [Openlp-core] [Merge] lp:~sfindlay/openlp/songs-import-powersong into lp:openlp

> If you're not actually doing something in the constructor, don't bother adding > it in. Oh of course, thanks Raoul. (I just copied from some other song import classes. May need a tidy up...) -- https://code.launchpad.net/~sfindlay/openlp/songs-import-powersong/+merge/104102 Your team OpenLP Cor

[Openlp-core] [Merge] lp:~sfindlay/openlp/songs-import-powersong into lp:openlp

The proposal to merge lp:~sfindlay/openlp/songs-import-powersong into lp:openlp has been updated. Description changed to: Added PowerSong song importer. * PowerSong is open source and windows-only * This importer imports individual song files. * Tested on win7 x64 and

[Openlp-core] [Merge] lp:~googol/openlp/vlc into lp:openlp

The proposal to merge lp:~googol/openlp/vlc into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/vlc/+merge/104230 -- https://code.launchpad.net/~googol/openlp/vlc/+merge/104230 Your team OpenLP Core is subscribed to bra

[Openlp-core] [Merge] lp:~googol/openlp/vlc into lp:openlp

The proposal to merge lp:~googol/openlp/vlc into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/vlc/+merge/104230 -- https://code.launchpad.net/~googol/openlp/vlc/+merge/104230 Your team OpenLP Core is subscribed

Re: [Openlp-core] [Merge] lp:~googol/openlp/vlc into lp:openlp

Review: Approve -- https://code.launchpad.net/~googol/openlp/vlc/+merge/104230 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : ht

Re: [Openlp-core] [Merge] lp:~sfindlay/openlp/songs-import-powersong into lp:openlp

Review: Needs Fixing 253 + def __init__(self, manager, **kwargs): 254 + """ 255 + Initialise the PowerSong importer. 256 + """ 257 + SongImport.__init__(self, manager, **kwargs) If you're not actually doing something in the constructor, don't bother adding it in. Otherwise i

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Bug 885874] Re: Song with mis matched formatting tags abends on render

** Changed in: openlp Importance: Medium => High ** Changed in: openlp Milestone: None => 1.9.10 ** Tags added: support-system -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/885874 Title: So

[Openlp-core] [Bug 986827] Re: Importing and then trying to pull up a imported presentation reports error

Branch merged, assuming that this is fixed. ** Changed in: openlp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/986827 Title: Importing and then trying

[Openlp-core] [Bug 825205] Re: Keep/restore selected book, chapters and verses when changing the bible translation

** Changed in: openlp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/825205 Title: Keep/restore selected book, chapters and verses when changing the bib

[Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles_fixes into lp:openlp

The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103167 -- https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103167

[Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles_fixes into lp:openlp

The proposal to merge lp:~orangeshirt/openlp/bibles_fixes into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103167 -- https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/

Re: [Openlp-core] [Merge] lp:~orangeshirt/openlp/bibles_fixes into lp:openlp

Review: Approve -- https://code.launchpad.net/~orangeshirt/openlp/bibles_fixes/+merge/103167 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Un

[Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232 -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232 Your team OpenLP Core is subscribed

[Openlp-core] [Bug 955807] Re: Display with three video cards is wrong

Set to invalid. ** Changed in: openlp Status: New => Invalid ** Changed in: openlp Milestone: None => 1.9.10 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/955807 Title: Display with thr

[Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

The proposal to merge lp:~m2j/openlp/cleanups into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232 -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232 Your team OpenLP Core is subsc

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

Review: Approve -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial2/+merge/104234 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Bug 966086] Re: Enabling VLC causes stack trace and prevents OpenLP from starting

** Changed in: openlp Status: Fix Committed => In Progress ** Changed in: openlp Status: In Progress => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/966086 Title: Enabli

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

Review: Approve -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Merge] lp:~googol/openlp/trivial2 into lp:openlp

Andreas Preikschat has proposed merging lp:~googol/openlp/trivial2 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial2/+merge/104234 Hello, - replaced numScreens by screenCount numScreens() can be found in the

[Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

Meinert Jordan has proposed merging lp:~m2j/openlp/cleanups into lp:openlp. Requested reviews: Andreas Preikschat (googol) For more details, see: https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104232 pythonifying code: - replace has_key() by key in dict - remove len() method from seq

[Openlp-core] [Merge] lp:~googol/openlp/bug-966086 into lp:openlp

The proposal to merge lp:~googol/openlp/bug-966086 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/bug-966086/+merge/103987 -- https://code.launchpad.net/~googol/openlp/bug-966086/+merge/103987 Your team OpenLP Cor

Re: [Openlp-core] [Merge] lp:~googol/openlp/vlc into lp:openlp

Review: Approve -- https://code.launchpad.net/~googol/openlp/vlc/+merge/104230 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : ht

[Openlp-core] [Merge] lp:~googol/openlp/vlc into lp:openlp

Andreas Preikschat has proposed merging lp:~googol/openlp/vlc into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/vlc/+merge/104230 - updated vlc.py -- https://code.launchpad.net/~googol/openlp/vlc/+merge/104230 Your te

[Openlp-core] [Merge] lp:~googol/openlp/bug-966086 into lp:openlp

The proposal to merge lp:~googol/openlp/bug-966086 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/bug-966086/+merge/103987 -- https://code.launchpad.net/~googol/openlp/bug-966086/+merge/103987 Your team Open

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

But the rest is okay. -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104021 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

Re: [Openlp-core] [Merge] lp:~m2j/openlp/cleanups into lp:openlp

Review: Needs Fixing Can you please revert your changes in mediacontroller.py, because I already have a proposal which changes the same things: https://code.launchpad.net/~googol/openlp/bug-966086/+merge/103987 -- https://code.launchpad.net/~m2j/openlp/cleanups/+merge/104021 Your team OpenLP Co

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/bug-966086 into lp:openlp

The proposal to merge lp:~googol/openlp/bug-966086 into lp:openlp has been updated. Description changed to: Hello, - various clean ups - fixed bug #966086 NOTE: I wrote the the vlc.py authors to double check if 1.1.0 is the lowest version it works with. For more details, see: https://code.la

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-966086 into lp:openlp

Here the answers: I have generated vlc.py with the vlc-1.1.7 and vlc-1.1.13 header (on MacOS X) tested that with the 1.1.7 and 1.1.13 VLC library (on Windows). Also, I did use vlc-0.9.10 (on MacOS X) but did not keep any results for that version. And: on the http://advene.org/downlo

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

> Receiver.send_message(u'openlp_phonon_creation') removal needs to be > considered. Cannot remember why this was added but it was so what is the > impact of it's loss. This was added because the phonon (media object?) creation was slow on some computer. However, we do not connect to this signa