Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/bug-870879 into lp:openlp

2012-06-18 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~j-corwin/openlp/bug-870879/+merge/110928 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubsc

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/bug-870879 into lp:openlp

2012-06-18 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~j-corwin/openlp/bug-870879/+merge/110928 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubsc

[Openlp-core] [Merge] lp:~googol/openlp/fixes into lp:openlp

2012-06-18 Thread Tim Bentley
The proposal to merge lp:~googol/openlp/fixes into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/fixes/+merge/110687 -- https://code.launchpad.net/~googol/openlp/fixes/+merge/110687 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~j-corwin/openlp/bug-870879 into lp:openlp

2012-06-18 Thread Tim Bentley
The proposal to merge lp:~j-corwin/openlp/bug-870879 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~j-corwin/openlp/bug-870879/+merge/110928 -- https://code.launchpad.net/~j-corwin/openlp/bug-870879/+merge/110928 Your tea

Re: [Openlp-core] [Bug 870879] Re: VLC causes process to continuing running on exit (Windows)

2012-06-18 Thread Samuel Findlay
I've tested this branch (remotely) and it solves the issue for me too. Bravo! On Jun 19, 2012 8:21 AM, "Jonathan Corwin" <870...@bugs.launchpad.net> wrote: > OK, I think I may have fixed this in lp:~j-corwin/openlp/bug-870879 > > -- > You received this bug notification because you are subscribed t

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue-507 into lp:openlp

2012-06-18 Thread phill
So assuming this was all wrapped in a verse tag, the tags are considered children. AAA is the text of the verse element.BBB is the text of the first element. CCC is the tail to the first element. DDD is the text of the second element. EEE is the tail to the second element. On Jun 18, 2012 11:3

[Openlp-core] [Bug 870879] Re: VLC causes process to continuing running on exit (Windows)

2012-06-18 Thread Jonathan Corwin
** Branch linked: lp:~j-corwin/openlp/bug-870879 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/870879 Title: VLC causes process to continuing running on exit (Windows) Status in OpenLP - Worship Pr

[Openlp-core] [Merge] lp:~j-corwin/openlp/bug-870879 into lp:openlp

2012-06-18 Thread Jonathan Corwin
Jonathan Corwin has proposed merging lp:~j-corwin/openlp/bug-870879 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #870879 in OpenLP: "VLC causes process to continuing running on exit (Windows)" https://bugs.launchpad.net/openlp/+bug/870879 For more details

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue-507 into lp:openlp

2012-06-18 Thread Jonathan Corwin
Review: Needs Information If the text looks something like AAABBBCCCDDDEEE Is CCC one of the subelements? -- https://code.launchpad.net/~phill-ridout/openlp/issue-507/+merge/110858 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing l

Re: [Openlp-core] [Merge] lp:~googol/openlp/theme into lp:openlp

2012-06-18 Thread Jonathan Corwin
Review: Needs Information Sorry it is probably too late for me to be looking at merge proposals... but I'll ask my silly question anyway... Is this going to have any adverse affect on performance, or is this code not called frequently? I'm just wondering why it isn't being done in the close eve

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/opensong_fix into lp:openlp

2012-06-18 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/opensong_fix/+merge/110890 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net U

Re: [Openlp-core] [Merge] lp:~googol/openlp/fixes into lp:openlp

2012-06-18 Thread Jonathan Corwin
Review: Approve I'm starting to wonder if any of the variable names obey the naming conventions! Approve. -- https://code.launchpad.net/~googol/openlp/fixes/+merge/110687 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https

[Openlp-core] [Bug 870879] Re: VLC causes process to continuing running on exit (Windows)

2012-06-18 Thread Jonathan Corwin
OK, I think I may have fixed this in lp:~j-corwin/openlp/bug-870879 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/870879 Title: VLC causes process to continuing running on exit (Windows) Status in

[Openlp-core] [Bug 870879] Re: VLC causes process to continuing running on exit (Windows)

2012-06-18 Thread Jonathan Corwin
I'm unchanging my mind again. The VLC causing the hanging issue (with latest VLC) seems to be cured. However there is a new reason for the process hanging which appears to have been introduced at r1976. At least for me. http://bazaar.launchpad.net/~openlp-core/openlp/trunk/revision/1976 -- You r

[Openlp-core] [Bug 953240] Re: OpenSong importer crashes at v1a verse markup

2012-06-18 Thread phill
I've just spotted this bug. Has this made it in to trunk? If so, I still get these issues! My branch https://code.launchpad.net/~phill- ridout/openlp/opensong_fix/+merge/110890 deals with this. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to O

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/opensong_fix into lp:openlp

2012-06-18 Thread phill
I'm a little confused, this seams covered by https://bugs.launchpad.net/openlp/+bug/953240 and has so called been fixed, but its still affecting me. -- https://code.launchpad.net/~phill-ridout/openlp/opensong_fix/+merge/110890 Your team OpenLP Core is requested to review the proposed merge of

[Openlp-core] [Merge] lp:~phill-ridout/openlp/opensong_fix into lp:openlp

2012-06-18 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/opensong_fix into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/opensong_fix/+merge/110890 A fix for a number of historic issues on the tracker: http://support.o

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-1014684 into lp:openlp

2012-06-18 Thread Tim Bentley
Review: Needs Fixing Obviously untested as the bug will still exist. -- https://code.launchpad.net/~googol/openlp/bug-1014684/+merge/110862 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Po

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue-507 into lp:openlp

2012-06-18 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/issue-507/+merge/110858 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

[Openlp-core] [Bug 1014684] Re: OpenLP doesn't start on Windows XP

2012-06-18 Thread Launchpad Bug Tracker
** Branch linked: lp:~googol/openlp/bug-1014684 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1014684 Title: OpenLP doesn't start on Windows XP Status in OpenLP - Worship Presentation Software: I

[Openlp-core] [Merge] lp:~googol/openlp/bug-1014684 into lp:openlp

2012-06-18 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-1014684 into lp:openlp has been updated. Description changed to: - fixed 1014684 (OpenLP doesn't start on Windows XP) For more details, see: https://code.launchpad.net/~googol/openlp/bug-1014684/+merge/110862 -- https://code.launchpad.net/~googol/ope

[Openlp-core] [Bug 1014684] Re: OpenLP doesn't start on Windows XP

2012-06-18 Thread Andreas Preikschat
** Changed in: openlp Importance: Undecided => Medium ** Changed in: openlp Status: New => In Progress ** Changed in: openlp Milestone: None => 1.9.10 ** Changed in: openlp Assignee: (unassigned) => Andreas Preikschat (googol) -- You received this bug notification because yo

[Openlp-core] [Merge] lp:~googol/openlp/bug-1014684 into lp:openlp

2012-06-18 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1014684 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1014684 in OpenLP: "OpenLP doesn't start on Windows XP" https://bugs.launchpad.net/openlp/+bug/1014684 For more details, see: https://code.l

[Openlp-core] [Merge] lp:~phill-ridout/openlp/issue-507 into lp:openlp

2012-06-18 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/issue-507 into lp:openlp. Requested reviews: Andreas Preikschat (googol) For more details, see: https://code.launchpad.net/~phill-ridout/openlp/issue-507/+merge/110858 A fix for issue 507. http://support.openlp.org/issues/507 The opensong dat

[Openlp-core] [Bug 1014684] [NEW] OpenLP doesn't start on Windows XP

2012-06-18 Thread Gyuris Gellért
Public bug reported: 1) Operating System: Windows XP (sp3) Home Edition, Hungarian 2) Version of OpenLP: 1.9.9 and nightly bild 3) Steps to reproduce: After installing OpenLP doesn't start. Only displays the Language selector, but after that crashes without any error message. 4) Debug log: 2012-0

[Openlp-core] [Merge] lp:~googol/openlp/image-queue into lp:openlp

2012-06-18 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/image-queue/+merge/110793 NOT TO BE REVIEWED PRIOR TO THE 1.9.10 RELEASE! Hello - update the im

[Openlp-core] [Bug 1014574] [NEW] openlp fails to be installed on Arch Linux

2012-06-18 Thread Andreas Preikschat
Public bug reported: Hello, I was trying to install openlp on Arch Linux via: yaourt -S openlp But as I am normally running from source some files already exist on my system. Fehler: Konnte den Vorgang nicht durchführen (In Konflikt stehende Dateien) openlp: /etc/profile.d/openlp.sh existiert i

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue-507 into lp:openlp

2012-06-18 Thread Andreas Preikschat
Review: Needs Fixing 9 +from lxml import objectify, etree No need for the etree import. 27 + Double new line. Please also add a docstring to your method. -- https://code.launchpad.net/~phill-ridout/openlp/issue-507/+merge/110682 Your team OpenLP Core is subscribed to branch lp:openlp. __