[Openlp-core] [Bug 963894] Re: openlp not starting on Mac if vlc not available

2012-08-21 Thread Brian Meyer
This code is already in a try statement inside vlcplayer.py, putting the try right around the dll loading allows it to indicate what is actually wrong when the issue happens, but it does not . I think i'd need to actually load the dll inside our codebase if vlc.py cannot be changed, recreating the

[Openlp-core] [Bug 963894] Re: openlp not starting on Mac if vlc not available

2012-08-21 Thread Brian Meyer
Correction: missed finishing the first paragraph * but it does not seem to work from outside the function which actually loads the dll. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/963894 Title:

[Openlp-core] [Bug 963955] Re: VLC backend for Mac OS X

2012-08-21 Thread Brian Meyer
What i was seeing was it would show the previous video when changing videos with your branch for a few seconds. Mainly the "stop" function is the only spot causing the issue and i left it so it can actually run if the video is playing. I tried calling the is_playing function in the vlcplayer.py fun

[Openlp-core] [Bug 963894] Re: openlp not starting on Mac if vlc not available

2012-08-21 Thread Jonathan Corwin
My "If so" should be "If the latter" -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/963894 Title: openlp not starting on Mac if vlc not available Status in OpenLP - Worship Presentation Software:

[Openlp-core] [Bug 963894] Re: openlp not starting on Mac if vlc not available

2012-08-21 Thread Jonathan Corwin
Agreed that we can't change vlc.py since we it gets updated now and again. Is it an OpenLP specific fix, or a fix that other developers using vlc.py will benefit from? If so, I'd suggest offering it to the VLC community and see if they'll merge it. Otherwise a solution in vlcplayer.py will need t

[Openlp-core] [Bug 963955] Re: VLC backend for Mac OS X

2012-08-21 Thread matysek
I tested your branch with running from python. I tested the playback in preview. The playback in preview is the same in your branch as in my branch. What specifically should be fixed with your changes? The following issues are still present, probably common to all media players on osx: - with

[Openlp-core] [Bug 963894] Re: openlp not starting on Mac if vlc not available

2012-08-21 Thread matysek
I confirm the issue with vlc not available is fixed. If vlc is not found it really cannot be activated in the available media players list. I think it would be better to have the fix in vlcplayer.py since oneday someone could replace vlc.py with newer version and vlc changes would be lost. --