[Openlp-core] [Merge] lp:~marmyshev/openlp/autoplay into lp:openlp

2012-12-17 Thread Dmitriy Marmyshev
Dmitriy Marmyshev has proposed merging lp:~marmyshev/openlp/autoplay into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~marmyshev/openlp/autoplay/+merge/140289 Andded new future: store autoplay option in service, start live the item with

[Openlp-core] [Merge] lp:~patrick-zakweb/openlp/bug-936281-newformat into lp:openlp

2012-12-17 Thread mohij
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into lp:openlp. Requested reviews: Andreas Preikschat (googol) Jonathan Corwin (j-corwin) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/1402

Re: [Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-17 Thread Meinert Jordan
Can you give some example for a setting, you can not realize (and which mases sense of cause)? According to the realization of the editor: I may add some "new" push button, which focuses on the corresponding cell, and some "delete" button, which removes the current row. That are the only points

Re: [Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-17 Thread Tim Bentley
Review: Needs Fixing Validation is not correct as I was able to create HTML with no end HTML. The editor does not give any clues as to what you need to do so is not intuitive. I think the UI is a backwards step so would look to other core developers for their opinion on the UI changes. Sorry

Re: [Openlp-core] [Question #216972]: Where can i request some features ?

2012-12-17 Thread dexter4000
Question #216972 on OpenLP changed: https://answers.launchpad.net/openlp/+question/216972 Status: Answered => Solved dexter4000 confirmed that the question is solved: Thanks Jonathan Corwin, that solved my question. -- You received this question notification because you are a member of Open

[Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-17 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/formattingtags into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140195 I forgot about this branch, and didn't realized, that it was never merged. Now

Re: [Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-17 Thread Meinert Jordan
> As a general point we should not mix reformatting and code changes but that > needs to be ratified!. It is rather a complete rewrite. I can submitt this in the old style, but I don't see the point. > 241-242 and 243-244 should be one line. This is done for purpose, as I think it is nicer to ma

Re: [Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-17 Thread Tim Bentley
Review: Needs Fixing Need to look at the UI ! As a general point we should not mix reformatting and code changes but that needs to be ratified!. 241-242 and 243-244 should be one line. 401-402 some line or 402 should be extra tab 554 should the regex be compiled into the CLASS once? As a side

[Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-17 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/formattingtags into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140176 I forgot about this branch, and didn't realized, that it was never merged.

[Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-17 Thread Meinert Jordan
Meinert Jordan has proposed merging lp:~m2j/openlp/formattingtags into lp:openlp. Commit message: formatting tag editor reworked Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140132 I forgot about this branch,

[Openlp-core] [Bug 1091151] Re: Need a blank line between verse splits in stageview

2012-12-17 Thread Jonathan Corwin
** Description changed: Win7 Build 2127 If I have verse 1 in two parts, eg: Verse 1, 4 lines of lyrics, Verse 1, 4 more lines of lyric, stageview does not separate V1 into two parts on the stageview display. - Stageview V1 shows both Verse 1's run together but when I change slides to the

[Openlp-core] [Bug 1091151] Re: Need a blank line between verse splits in stageview

2012-12-17 Thread John Cegalis
** Summary changed: - stageview display not working correctly + Need a blank line between verse splits in stageview -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1091151 Title: Need a blank line be

[Openlp-core] [Bug 1091151] [NEW] stageview display not working correctly

2012-12-17 Thread John Cegalis
Public bug reported: Win7 Build 2127 If I have verse 1 in two parts, eg: Verse 1, 4 lines of lyrics, Verse 1, 4 more lines of lyric, stageview does not separate V1 into two parts on the stageview display. Stageview V1 shows both Verse 1's run together but when I change slides to the second par