Meinert Jordan has proposed merging lp:~m2j/openlp/argument_name_fix into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/argument_name_fix/+merge/140804
Minor fix for initial disabeling of up and down arrow.
--
https://c
Andreas Preikschat (googol) wrote:
> I had a chat with the other devs about your proposal.
> And most of us found your solution better than the old dialog,
> but also less intuitive. Do you have any suggest to improve this?
First: Do you have seen versions with additional "new" and "delete" button
> Had 5 mins to have a look and I must say it is better but still cannot
> understand why it needed a re-write.
Well, the initial reason was to add some validation. Especially to enforce
correct opening and closing tags. Without this it is not clear, how to handle
custom tags in my new lyrics edi
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Jonathan Corwin (j-corwin)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/1407
Samuel Mehrbrodt has proposed merging
lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140779
Now using map()
I also removed some unne
Commit again and then use the "Resubmit proposal" link on this page.
--
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140651
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net
I see, I'm at it. Should I commit again in this branch or create a new one?
--
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140651
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launch
Review: Needs Fixing
map is just better here: http://docs.python.org/2/library/functions.html#map
--
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140651
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Maili
Review: Needs Fixing
We use unicode strings, so u'xfce' please.
--
https://code.launchpad.net/~arjan-i/openlp/xfce-fix/+merge/140751
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
Review: Disapprove
--
https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140598
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.laun
** Branch linked: lp:openlp
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1085921
Title:
Locale aware sorting has broken the song export form
Status in OpenLP - Worship Presentation Software:
Con
The proposal to merge lp:~j-corwin/openlp/bug-1085921 into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~j-corwin/openlp/bug-1085921/+merge/139769
--
https://code.launchpad.net/~j-corwin/openlp/bug-1085921/+merge/139769
Your team O
Review: Needs Information
I had a chat with the other devs about your proposal. And most of us found your
solution better than the old dialog, but also less intuitive. Do you have any
suggest to imporve this?
--
https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140195
Your team OpenL
Had 5 mins to have a look and I must say it is better but still cannot
understand why it needed a re-write.
It is buggy though.
1) Restore Defaults should set the list back to the default list. It does
not.
2) Hit new and it creates a new line. Good. Add a tag and another new
line appears. Bug
Review: Needs Fixing
Had 5 mins to have a look and I must say it is better but still cannot
understand why it needed a re-write.
It is buggy though.
1) Restore Defaults should set the list back to the default list. It does not.
2) Hit new and it creates a new line. Good. Add a tag and another
Arjan Schrijver has proposed merging lp:~arjan-i/openlp/xfce-fix into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1092121 in OpenLP: "Interface unusable when run on XFce"
https://bugs.launchpad.net/openlp/+bug/1092121
For more details, see:
https://code.launch
** Branch linked: lp:~arjan-i/openlp/xfce-fix
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1092121
Title:
Interface unusable when run on XFce
Status in OpenLP - Worship Presentation Software:
Ne
Could you use
files = map(unicode, files)
instead.
--
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140651
Your team OpenLP Core is requested to review the proposed merge of
lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0.
_
My guess is Tim is expecting it to force end html to be entered. However saying
that, it doesn't currently force this in trunk, so I don't know why it is
important here. Also doing so might prevent self closing standalone tags such
as
--
https://code.launchpad.net/~m2j/openlp/formattingtags/+
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/argument_name_fix/+merge/140663
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
U
The proposal to merge lp:~j-corwin/openlp/bug-1085921 into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~j-corwin/openlp/bug-1085921/+merge/139769
--
https://code.launchpad.net/~j-corwin/openlp/bug-1085921/+merge/139769
Your
Review: Approve
--
https://code.launchpad.net/~j-corwin/openlp/bug-1085921/+merge/139769
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubs
type() will be correct for sure. I knew, that there is no QList in PyQt, but I
missed, that they still use QStringList. So I remembered wrong.
--
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140651
Your team OpenLP Core is requested to review the proposed merge of
lp
Please rather submit a merge request, this way our entire team can
verify your patch.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1092121
Title:
Interface unusable when run on XFce
Status in Open
type() and the docs tell somethin else:
http://www.riverbankcomputing.co.uk/static/Docs/PyQt4/html/qfiledialog.html#getOpenFileNames
--
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140651
Your team OpenLP Core is requested to review the proposed merge of
lp:~sam92/ope
Public bug reported:
When OpenLP is run on Linux with the XFce window manager, the default setting
is to turn X11 Bypass on. This is incorrect, since it causes all screen updates
and mouse input to be ignored, effectively making the graphical interface of
the computer unusable until OpenLP is s
Meinert Jordan has proposed merging lp:~m2j/openlp/argument_name_fix into
lp:openlp/2.0.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/argument_name_fix/+merge/140663
Minor fix for initial disabeling of up and down arrow.
--
https:
IIRC QtGui.QFileDialog.getOpenFileNames() returns a PYTHON list of QStrings.
--
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140651
Your team OpenLP Core is requested to review the proposed merge of
lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0.
_
New question #217165 on OpenLP:
https://answers.launchpad.net/openlp/+question/217165
Hi Guys Just a question can we not have a update version available via the Tool
option button. Also if we can add some nice default bg pictures and animations.
Also in the Song list if we have a drop down list
Meinert Jordan has proposed merging lp:~m2j/openlp/formattingtags into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140652
I forgot about this branch, and didn't realized, that it was never merged. Now
Samuel Mehrbrodt has proposed merging
lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140651
Here's a new try.
--
https://code.launchpa
I don't want to argue with you and I can only lose. But you bypassed my
question: Two days ago I asked you to post the falsely verified HTML, you
already tested. No more testing.
It doesn't help to tag a merge request as "need fixing" in first place, without
explaining what's going wrong.
I've
Review: Needs Fixing
Marking as Needs fixing as Raoul did not select that ;-)
--
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/140280
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://lau
Review: Needs Fixing
Fixes for 2.0 must be based on the 2.0 code base and not the development trunk.
Please resubmit when based on the correct code base.
--
https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140598
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
I am reviewing visually in mylunch time . I have no time to fire up code
and run it. Most changes are simple yours is a big change and a
signifficant behaviour change which cannot be fast pathed.
Tim Bentley (Mobile)
On Dec 19, 2012 7:59 AM, "Meinert Jordan" wrote:
> > Sorry but limited time th
Modify it. The problem might get triggered in other plugins as well.
--
https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140540
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~open
Thanks for reviewing. I did a merge request towards the lp:openlp/2.0 branch.
Or should modify the patch according to what Meinert said in Comment #1?
--
https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140540
Your team OpenLP Core is subscribed to branch lp:openlp.
__
Sorry, that's what I meant to say.
On 19 Dec 2012 08:06, "Meinert Jordan" wrote:
> Phill: Tim is right.
> I guess there should be a merge request towards lp:openlp/2.0 branch.
> --
>
> https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140540
> You are subscribed to branch l
Phill: Tim is right.
I guess there should be a merge request towards lp:openlp/2.0 branch.
--
https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140540
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: http
39 matches
Mail list logo
