[Openlp-core] [Bug 1092121] Re: Interface unusable when run on XFce

2012-12-22 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1092121 Title: Interface unusable when run on XFce Status in OpenLP - Worship Presentation Software: New Bug description

[Openlp-core] [Merge] lp:~arjan-i/openlp/xfce-fix into lp:openlp

2012-12-22 Thread noreply
The proposal to merge lp:~arjan-i/openlp/xfce-fix into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~arjan-i/openlp/xfce-fix/+merge/140833 -- https://code.launchpad.net/~arjan-i/openlp/xfce-fix/+merge/140833 Your team OpenLP Co

[Openlp-core] [Bug 1092121] Re: Interface unusable when run on XFce

2012-12-22 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp/2.0 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1092121 Title: Interface unusable when run on XFce Status in OpenLP - Worship Presentation Software: New Bug descrip

Re: [Openlp-core] [Merge] lp:~arjan-i/openlp/xfce-fix into lp:openlp

2012-12-22 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~arjan-i/openlp/xfce-fix/+merge/140833 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0

2012-12-22 Thread Meinert Jordan
Samuel: I encourage you, to finish it, as you're almost there. - The current line 10 would be completely fine as patch - You may add the comment of line 9 as well (in my own changes, I wouldn't mention that, but feel free to do it anyhow) - As 2.0 is stable, the changes should be limited to the ab

[Openlp-core] [Bug 1093184] [NEW] UnicodeError, when importing presentation files with non-ASCII in file name

2012-12-22 Thread Meinert Jordan
Public bug reported: *OpenLP Bug Report* Version: {u'full': u'2.0', u'version': u'2.0', u'build': None} --- Details of the Exception. --- When importing presentations, with a file name containing non-ASCII characters, a exception is thrown. Reproducable: always Reason: file list of the open dia

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0

2012-12-22 Thread Jonathan Corwin
m2j: Since you seem to know what the bug is, could you add a bug report, link it, and then point Sam in the right direction here please - i.e. what is cleanup and what is bug fix? Thanks. -- https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140779 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0

2012-12-22 Thread Samuel Mehrbrodt
Please, one of you can do the fix. I don't know how to do it right. -- https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140779 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-779201-2 into lp:openlp

2012-12-22 Thread Jonathan Corwin
Do you know when you think you'll have enough time to finish this off? We're now holding off other merge requests until this finished so you don't need to keep fixing conflicts or playing catchup, however if you don't think you'll have time to finish before March then we might reconsider :) --

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0

2012-12-22 Thread Tim Bentley
Then there should be one IMO 2.0 is bug fix only -- https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140779 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post t

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0

2012-12-22 Thread Meinert Jordan
> Is there a bug this relates to? Yes: A exception triggered on importing presentations with non-ASCII chars. But there's no bug report on Launchpad. -- https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140779 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. _

Re: [Openlp-core] [Merge] lp:~patrick-zakweb/openlp/bug-936281-newformat into lp:openlp

2012-12-22 Thread Tim Bentley
Review: Needs Fixing This merge is being delayed to allow lp:~googol/openlp/bug-779201 to land This will cause a change being required Sorry. -- https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/140780 Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/autoplay into lp:openlp

2012-12-22 Thread Tim Bentley
Review: Needs Fixing Please removed comment out code sorry. Also this merge will be delayed to allow lp:~googol/openlp/bug-779201 to land. -- https://code.launchpad.net/~marmyshev/openlp/autoplay/+merge/140536 Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-presentation into lp:openlp

2012-12-22 Thread Tim Bentley
Review: Disapprove This will not be merged into trunk until lp:~googol/openlp/bug-779201 has landed and this looks like it will make this fix unnecessary. -- https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140540 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0

2012-12-22 Thread Tim Bentley
Review: Needs Fixing Bug fixes only for 2.0 no cleanups are allowed. Is there a bug this relates to? -- https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140779 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Ma

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-non-ascii-path into lp:openlp/2.0

2012-12-22 Thread Meinert Jordan
Have you carefully checked all possible calls of loadList()? I would feel better, if we limit the change to the bug fix, and do not include cleanups. -- https://code.launchpad.net/~sam92/openlp/fix-import-non-ascii-path/+merge/140779 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. _