Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-04-08 Thread Dmitriy Marmyshev
What is it DnD? DnD = Drag and Drop - actually it is from the trunk code - there is procedure activateDnD() for list_view -- https://code.launchpad.net/~marmyshev/openlp/presentation/+merge/157509 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-04-08 Thread Dmitriy Marmyshev
One small issue that when the user double clicks a ppt item in openlp then the error 'The presentation /filename is incomplete, please reload.'. - this is probably caused by not generating presentation preview. Can you explane more detailly about this? Did you reload it just once and

[Openlp-core] [Bug 1165905] Re: import generic doc on OSX

2013-04-08 Thread matysek
For implementation we could consider call Java api of libreoffice with python. For that we could consider the following python package: https://pypi.python.org/pypi/py4j -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-04-08 Thread matysek
One small issue that when the user double clicks a ppt item in openlp then the error 'The presentation /filename is incomplete, please reload.'. - this is probably caused by not generating presentation preview. Can you explane more detailly about this? Did you reload it just once and

Re: [Openlp-core] [Merge] lp:~mzibricky/openlp/bug-1160506_2.0 into lp:openlp/2.0

2013-04-08 Thread Raoul Snyman
Review: Needs Fixing 104 + size = self._getFileSize(u'%s%s/%s' % (self.baseurl, bibles_dir, filename)) I know this works, by technically one should use urlparse.urljoin: http://docs.python.org/2/library/urlparse.html#urlparse.urljoin --

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-04-08 Thread Raoul Snyman
Review: Needs Information try this: 1. launch OpenLP 2. turn off Presentation plugin 3. Quit app 4. Launch OpenLP 5. turn on Presentation plugin 6. Add some presentations for tests, using Select presentations dialog. Are our users going to have to do this? If so, you need to find a

[Openlp-core] [Merge] lp:~googol/openlp/bug-1146964-2.0 into lp:openlp/2.0

2013-04-08 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/bug-1146964-2.0 into lp:openlp/2.0 has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol/openlp/bug-1146964-2.0/+merge/154178 --

Re: [Openlp-core] [Merge] lp:~trb143/openlp/cherrypy into lp:openlp

2013-04-08 Thread Raoul Snyman
Review: Needs Fixing def sha_password_encrypter(password): Try as I might, I can't let this pass... this is not encryption, it is just hashing. encryption means you should be able to decrypt it, which you can't with sha. Please rename to make_sha_hash or something. --

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-04-08 Thread matysek
Are our users going to have to do this? If so, you need to find a solution, we can't expect our users to have to run workarounds for a bug that we should be able to fix. No, our users should not do that. It's just seems that this issue is not caused by Dmitriy's code but by instability of

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-04-08 Thread Dmitriy Marmyshev
Of course, no! Who can help with this bag? Because I have no clue. On Mon, Apr 8, 2013 at 4:10 PM, Raoul Snyman ra...@snyman.info wrote: Review: Needs Information try this: 1. launch OpenLP 2. turn off Presentation plugin 3. Quit app 4. Launch OpenLP 5. turn on Presentation

Re: [Openlp-core] [Merge] lp:~patrick-zakweb/openlp/duplicate-removal-review into lp:openlp

2013-04-08 Thread Raoul Snyman
Just delete the merge proposal. -- https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/157517 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-1133237 into lp:openlp

2013-04-08 Thread Andreas Preikschat
393 you are testing the method but the method is called by the Registry so would that not be a more valid test? I think that this is not in the scope of the test. -- https://code.launchpad.net/~googol/openlp/bug-1133237/+merge/156311 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~googol/openlp/bug-1133237 into lp:openlp

2013-04-08 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1133237 into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) Tim Bentley (trb143) Related bugs: Bug #1133237 in OpenLP: Our General settings section conflicts with Qt https://bugs.launchpad.net/openlp/+bug/1133237

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-1133237 into lp:openlp

2013-04-08 Thread Tim Bentley
Review: Approve Ok but you are calling something that is only called via the registry so then you need a test to make sure it is registered correctly. -- https://code.launchpad.net/~googol/openlp/bug-1133237/+merge/156311 Your team OpenLP Core is subscribed to branch lp:openlp.