Re: [Openlp-core] [Merge] lp:~googol/openlp/python3-bzrlib into lp:openlp

2013-04-16 Thread Andreas Preikschat
> Yes, "I" updated the .version file. Actually the I run the setup.py which > updated the file, so you know that the replaced code works as expected ;) Well, it should say "2.1.0-bzr2233". Is this because I have 2.0 and trunk in one shared repo? -- https://code.launchpad.net/~googol/openlp/pytho

Re: [Openlp-core] [Merge] lp:~googol/openlp/python3-bzrlib into lp:openlp

2013-04-16 Thread Andreas Preikschat
Yes, "I" updated the .version file. Actually the I run the setup.py which updated the file, so you know that the replaced code works as expected ;) -- https://code.launchpad.net/~googol/openlp/python3-bzrlib/+merge/159212 Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~googol/openlp/python3-bzrlib into lp:openlp

2013-04-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/python3-bzrlib into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~googol/openlp/python3-bzrlib/+merge/159212 Hello, - Removed some code not compatible with python 3 -- ht

Re: [Openlp-core] [Merge] lp:~googol/openlp/python3-bzrlib into lp:openlp

2013-04-16 Thread Andreas Preikschat
Ah I mixed things up here. Obviously I only wanted to remove the bzrlib code. Thanks for point out :) -- https://code.launchpad.net/~googol/openlp/python3-bzrlib/+merge/159021 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing lis

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1114457 into lp:openlp

2013-04-16 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with lp:~googol/openlp/bug-1116528 as a prerequisite. Requested reviews: Andreas Preikschat (googol) Raoul Snyman (raoul-snyman) Related bugs: Bug #1114457 in OpenLP: "Easy Worship importer progress bar is out" http

Re: [Openlp-core] [Merge] lp:~googol/openlp/python3-bzrlib into lp:openlp

2013-04-16 Thread Raoul Snyman
And yet you removed 2 OpenLP 1 (aka sqlite 2) files. See the diff. -- https://code.launchpad.net/~googol/openlp/python3-bzrlib/+merge/159021 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core P

Re: [Openlp-core] [Merge] lp:~googol/openlp/python3-sqlite into lp:openlp

2013-04-16 Thread Andreas Preikschat
Question: Should I remove BibleFormat.set_availability() and BibleFormat.set_get_availability()? It is dead code currently. I'd go for removing it. If you don't disagree I'll do so soon. -- https://code.launchpad.net/~googol/openlp/python3-sqlite/+merge/159188 Your team OpenLP Core is requested

[Openlp-core] [Merge] lp:~googol/openlp/python3-sqlite into lp:openlp

2013-04-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/python3-sqlite into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/python3-sqlite/+merge/159188 Hello, - removed code using the sqlite package (which is not ava

[Openlp-core] [Merge] lp:~googol/openlp/python3-sqlite into lp:openlp

2013-04-16 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/python3-sqlite into lp:openlp has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~googol/openlp/python3-sqlite/+merge/159183 -- https://code.launchpad.net/~googol/openlp/python3-sqlite/+merge/1

Re: [Openlp-core] [Merge] lp:~googol/openlp/python3-sqlite into lp:openlp

2013-04-16 Thread Andreas Preikschat
Note, didn't run tests now (sorry). -- https://code.launchpad.net/~googol/openlp/python3-sqlite/+merge/159183 Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/python3-sqlite into lp:openlp. ___ Mailing list: https://

[Openlp-core] [Merge] lp:~googol/openlp/python3-sqlite into lp:openlp

2013-04-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/python3-sqlite into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/python3-sqlite/+merge/159183 Hello, - removed code using the sqlite package (which is not ava

Re: [Openlp-core] [Merge] lp:~googol/openlp/python3-bzrlib into lp:openlp

2013-04-16 Thread Andreas Preikschat
> What about the code in the import wizards which imports and puts these > importers into the gui? I am not removing the sqlite code here ;) Anyway, the setup.py script also uses bzrlib (to be replaced as well) -- https://code.launchpad.net/~googol/openlp/python3-bzrlib/+merge/159021 Your team O

Re: [Openlp-core] [Merge] lp:~googol/openlp/python3-bzrlib into lp:openlp

2013-04-16 Thread Raoul Snyman
Review: Needs Fixing What about the code in the import wizards which imports and puts these importers into the gui? -- https://code.launchpad.net/~googol/openlp/python3-bzrlib/+merge/159021 Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Bug 1165905] Re: import generic doc on OSX

2013-04-16 Thread Jonathan Corwin
So we'd convert it to a plain text file and then import that? This would be OK for the generic doc/ppt as long as page breaks/slide breaks can be detected in the output file somehow. However the "Songs of Fellowship" import relies on knowing where bold/italics/breaks are etc to figure out where v

[Openlp-core] [Bug 1165905] Re: import generic doc on OSX

2013-04-16 Thread matysek
Probably better and crossplatform way would be to use unoconv ( https://github.com/dagwieers/unoconv ) - Unoconv is is a python script that should be run as terminal app with the python bundled with libre/openoffice. - we could use 'unoconv' in openlp to find the openoffice installation then run