Phill has proposed merging lp:~phill-ridout/openlp/1114457 into lp:openlp with
lp:~googol/openlp/bug-1116528 as a prerequisite.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
Related bugs:
Bug #1114457 in OpenLP: "Easy Worship importer progress bar is out"
http
Because I wanted to keep the constants together.
--
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/159202
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-
Review: Needs Fixing
125 +TEST_PATH = os.path.abspath(os.path.join(os.path.dirname(__file__),
u'../../../resources/easyworshipsongs'))
126 +SONG_TEST_DATA = [{u'title': u'Amazing Grace',
Why are these constants below some other classes?
--
https://code.launchpad.net/~phill-ridout/openlp
Yes, the shared repos share tags too. There doesn't seem to be an easy way
around this short of creating a new shared repo just for version 2.0.x
--
https://code.launchpad.net/~googol/openlp/python3-bzrlib/+merge/159212
Your team OpenLP Core is subscribed to branch lp:openlp.
___
If it's not doing anything you can remove it.
--
https://code.launchpad.net/~googol/openlp/python3-sqlite/+merge/159188
Your team OpenLP Core is requested to review the proposed merge of
lp:~googol/openlp/python3-sqlite into lp:openlp.
___
Mailing list
Jenkins does have ICU now.
--
https://code.launchpad.net/~googol/openlp/last-version-fix/+merge/158963
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpa
Andreas Preikschat has proposed merging lp:~googol/openlp/python3-sqlite into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/python3-sqlite/+merge/159488
Hello,
- removed code using the sqlite package (which is not ava
> Would like extra test then to cover the call from the Registry as this is the
> only way the code gets called.
Where the method is called does not matter really. I am testing the method and
not the code which calls the method.
--
https://code.launchpad.net/~googol/openlp/bug-1133237/+merge/157
Andreas Preikschat has proposed merging lp:~googol/openlp/bs4 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/bs4/+merge/159468
Hello,
- ported code to beautifulsoup 4
- moved regular expressions to the top
- fixed
Review: Needs Fixing
> # WHEN: pyodbc raises and unspecified exception
> mocked_pyodbc.connect.side_effect = Exception()
>
> # THEN: doImport should return None, and pyodbc, translate & logError are
> called with known calls
> self.assertIsNone(importer.doImport(), u'doImport should return None
> I use *.key, *.ppt and *.pptx documents.
> I use MS Office 2011 for Mac with localized interface.
> I use both latin and non-latin characters in full file names.
> I use both english and translated interface of OpenLP.
>
> and create_thumbnails() works good.
The following function does not crea
Review: Needs Fixing
--
https://code.launchpad.net/~googol/openlp/python3-bzrlib/+merge/159212
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
I use *.key, *.ppt and *.pptx documents.
I use MS Office 2011 for Mac with localized interface.
I use both latin and non-latin characters in full file names.
I use both english and translated interface of OpenLP.
and create_thumbnails() works good.
On Fri, Apr 12, 2013 at 11:17 PM, matysek wrot
13 matches
Mail list logo
