[Openlp-core] [Bug 1173749] Re: Songs with mismatching formatting tags still throw an exception

2013-08-10 Thread Oliver Wieland
I think the problem is, that the method '_get_missing_tags' only checks for 'not closed' tags, but not for 'not opened'. I'm nearly a Phyton newbie, therefore I don't understand the complete code around this method and the following calls in 'song_to_xml', so I'm sorry that i cannot fix the

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Phill
I have not run your code, but why return u'{su}{/su}' rather than an empty string? -- https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179526 Your team OpenLP Core is requested to review the proposed merge of lp:~oliwee/openlp/HideBibleVerses into lp:openlp.

[Openlp-core] [Bug 1051699] Re: Bibles add option to not display chapter and verse numbers

2013-08-10 Thread Phill
** Changed in: openlp/trunk Assignee: (unassigned) = Oliver Wieland (oliwee) ** Changed in: openlp/trunk Status: Confirmed = In Progress ** Changed in: openlp/trunk Milestone: None = 2.1.1 -- You received this bug notification because you are a member of OpenLP Core, which is

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Oliver Wieland
I have not run your code, but why return u'{su}{/su}' rather than an empty string? I was not sure if this was needed... If not, a empty string would be of course the better way :) -- https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179526 Your team OpenLP Core is requested to

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Oliver Wieland
I was not sure if this was needed... If not, a empty string would be of course the better way :) changed that. Do I have to create a new merge proposal? -- https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179526 Your team OpenLP Core is requested to review the proposed merge of

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Phill
There should be a link to resubmit (top right) -- https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179526 Your team OpenLP Core is requested to review the proposed merge of lp:~oliwee/openlp/HideBibleVerses into lp:openlp. ___ Mailing

[Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Oliver Wieland
Oliver Wieland has proposed merging lp:~oliwee/openlp/HideBibleVerses into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1051699 in OpenLP: Bibles add option to not display chapter and verse numbers https://bugs.launchpad.net/openlp/+bug/1051699 For more

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0

2013-08-10 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1209515 in OpenLP: getFileNames corrupts file names that use special chars https://bugs.launchpad.net/openlp/+bug/1209515 For more details,

[Openlp-core] [Bug 1209515] Re: getFileNames corrupts file names that use special chars

2013-08-10 Thread Phill
Reported to Qt: https://bugreports.qt-project.org/browse/QTBUG-32897 ** Branch linked: lp:~phill-ridout/openlp/1209515_2.0 ** Changed in: openlp/2.0 Assignee: (unassigned) = Phill (phill-ridout) ** Changed in: openlp/2.0 Status: Confirmed = In Progress -- You received this bug

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Tim Bentley
Review: Needs Fixing No .version file in merge merge If you are adding this option should the chapter be on the footer? -- https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179565 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Bug 1210774] [NEW] wrong links on forum page

2013-08-10 Thread Oliver Wieland
Public bug reported: on the forum page, the links Support and Development are not correct. They link to openlp.org/support and openlp.org/development instead of /openlp.org/node/324 and /openlp.org/node/864 ** Affects: openlp Importance: Undecided Status: New ** Tags: website **

[Openlp-core] [Bug 1210774] Re: wrong links on forum page

2013-08-10 Thread Phill
Hey Oliver, I don't see what the issue is here. Both sets of links point to the same page. Could you be a bit clear about which links too? The ones on the top menu bar, in the navigation on the right? ** Also affects: openlp/website Importance: Undecided Status: New ** Changed in:

[Openlp-core] [Bug 1210774] Re: wrong links on forum page

2013-08-10 Thread Oliver Wieland
of course without leading '/' -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1210774 Title: wrong links on forum page Status in OpenLP - Worship Presentation Software: Invalid Status in OpenLP

[Openlp-core] [Bug 1210774] Re: wrong links on forum page

2013-08-10 Thread Oliver Wieland
on http://forums.openlp.org/, in the top menu bar, 'Support' links to openlp.org/support instead of /openlp.org/node/324 and Development links to openlp.org/development instead of /openlp.org/node/864 -- You received this bug notification because you are a member of OpenLP Core, which is

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Oliver Wieland
No .version file in merge merge Have I to delete the existing .version file? If you are adding this option should the chapter be on the footer? In my opinion this option should not affect the footer, so it is correct to show the chapter there. --

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Oliver Wieland
found another issue in my code. I will resubmit as soon I know what to do with the .version file -- https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179565 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0

2013-08-10 Thread Andreas Preikschat
Review: Needs Fixing No need to add a constructor. Make the getOpenFileNames method static -- https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+merge/179567 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0

2013-08-10 Thread Andreas Preikschat
Review: Needs Fixing 113 + 'Abbreviated font pointsize unit')ad -- https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+merge/179567 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Tim Bentley
Review: Needs Fixing You need to have a bzrignore file. It should be covered on the wiki. You also need to add some tests to cover the new functionality. Try and test the method you are changing. -- https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179565 Your team OpenLP Core

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-10 Thread Tim Bentley
Review: Needs Fixing You need to have a bzrignore file. It should be covered on the wiki. You also need to add some tests to cover the new functionality. Try and test the method you are changing. -- https://code.launchpad.net/~oliwee/openlp/HideBibleVerses/+merge/179565 Your team OpenLP Core

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0

2013-08-10 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0. Requested reviews: Andreas Preikschat (googol) Related bugs: Bug #1209515 in OpenLP: getFileNames corrupts file names that use special chars https://bugs.launchpad.net/openlp/+bug/1209515 For more details,