Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1194610_2.0/+merge/181199
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
Phill has proposed merging lp:~phill-ridout/openlp/1194610_2.0 into
lp:openlp/2.0.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1194610 in OpenLP: "[support-system] SongShowPlus traceback"
https://bugs.launchpad.net/openlp/+bug/1194610
For more d
The proposal to merge lp:~phill-ridout/openlp/1209515_2.0 into lp:openlp/2.0
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+merge/181144
--
https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+me
Review: Needs Fixing
Please drop the loop. Just return retrieve_windows_encoding()
--
https://code.launchpad.net/~phill-ridout/openlp/1194610_2.0/+merge/181159
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launc
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+merge/181144
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
Is line 90 right? It seems to go against Roauls last comment
--
https://code.launchpad.net/~phill-ridout/openlp/1194610_2.0/+merge/181159
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
P
Phill has proposed merging lp:~phill-ridout/openlp/1194610_2.0 into
lp:openlp/2.0.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
Related bugs:
Bug #1194610 in OpenLP: "[support-system] SongShowPlus traceback"
https://bugs.launchpad.net/openlp/+bug/1194610
For more d
Marking this as "won't fix" in 2.0 as we need to rework the process
completely.
** Changed in: openlp/2.0
Status: Incomplete => Won't Fix
** Changed in: openlp/2.0
Milestone: 2.0.2 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscri
** Branch linked: lp:openlp/2.0
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1088800
Title:
Macro enabled presentations are not shown in OpenLP
Status in OpenLP - Worship Presentation Software:
** Changed in: openlp/2.0
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1088800
Title:
Macro enabled presentations are not shown in OpenLP
Status in Open
The proposal to merge lp:~raoul-snyman/openlp/bug-1088800-2.0 into
lp:openlp/2.0 has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1088800-2.0/+merge/181134
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1088800-2
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+merge/181144
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
** Changed in: openlp/2.0
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1194622
Title:
[support-system] Traceback when importing bible with disabled bible
** Changed in: openlp/2.0
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1213254
Title:
OpenLP 1 database importer crashes when encountering control chars
The proposal to merge lp:~raoul-snyman/openlp/bug-1194622-2.0 into
lp:openlp/2.0 has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1194622-2.0/+merge/181133
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1194622-2
** Branch linked: lp:openlp/2.0
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1213254
Title:
OpenLP 1 database importer crashes when encountering control chars
Status in OpenLP - Worship Presentati
** Changed in: openlp/2.0
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1197659
Title:
Delete button in Configure Formatting Tags gets focus
Status in Op
** Changed in: openlp/2.0
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1212801
Title:
Theme in Song Editor is Never Reset
Status in OpenLP - Worship Pre
** Changed in: openlp/2.0
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1184869
Title:
Webbible import fails
Status in OpenLP - Worship Presentation Soft
** Branch linked: lp:openlp/2.0
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1197659
Title:
Delete button in Configure Formatting Tags gets focus
Status in OpenLP - Worship Presentation Software:
The proposal to merge lp:~phill-ridout/openlp/1213254_2.0 into lp:openlp/2.0
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1213254_2.0/+merge/180938
--
https://code.launchpad.net/~phill-ridout/openlp/1213254_2.0/+merge/18
The proposal to merge lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766
--
https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/17
** Branch linked: lp:openlp/2.0
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1212801
Title:
Theme in Song Editor is Never Reset
Status in OpenLP - Worship Presentation Software:
In Progress
Stat
** Branch linked: lp:openlp/2.0
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1184869
Title:
Webbible import fails
Status in OpenLP - Worship Presentation Software:
In Progress
Status in OpenLP 2
The proposal to merge lp:~phill-ridout/openlp/1197659_2.0 into lp:openlp/2.0
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1197659_2.0/+merge/180727
--
https://code.launchpad.net/~phill-ridout/openlp/1197659_2.0/+merge/18
The proposal to merge lp:~raoul-snyman/openlp/bug-1212801-2.0 into
lp:openlp/2.0 has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1212801-2.0/+merge/180409
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1212801-2
OK, looks like something was lost in translation here. I went back and looked
through the past revisions, and it looks like instead of using "cp1252" you
should be using the retrieve_windows_encoding() method. Just please don't use
that while True loop - that is looking for trouble.
--
https://
Phill has proposed merging lp:~phill-ridout/openlp/1209515_2.0 into
lp:openlp/2.0.
Requested reviews:
Phill (phill-ridout)
Andreas Preikschat (googol)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #1209515 in OpenLP: "getFileNames corrupts file names that use "special
chars""
https://b
The proposal to merge lp:~phill-ridout/openlp/1197659_2.0 into lp:openlp/2.0
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1197659_2.0/+merge/180727
--
https://code.launchpad.net/~phill-ridout/openlp/1197659_2.0/+me
The code is all wrong. Why are we saving the tags before the user edits
them? We also don't check that the tag is blank, so anyone could enter a
blank tag and it wouldn't stop them.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1197659_2.0/+merge/180727
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
The proposal to merge lp:~phill-ridout/openlp/1213254_2.0 into lp:openlp/2.0
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1213254_2.0/+merge/180938
--
https://code.launchpad.net/~phill-ridout/openlp/1213254_2.0/+me
The proposal to merge lp:~phill-ridout/openlp/1184869_2.0 into lp:openlp/2.0
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766
--
https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+me
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1213254_2.0/+merge/180938
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
Review: Needs Fixing
No comments/doc strings. Why this class? Why this method? Please explain it!
--
https://code.launchpad.net/~phill-ridout/openlp/1209515_2.0/+merge/180686
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1184869_2.0/+merge/179766
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1212801-2.0/+merge/180409
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpa
The proposal to merge lp:~raoul-snyman/openlp/bug-1212801-2.0 into
lp:openlp/2.0 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1212801-2.0/+merge/180409
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-121
The proposal to merge lp:~raoul-snyman/openlp/bug-1194622-2.0 into
lp:openlp/2.0 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1194622-2.0/+merge/181133
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-119
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1194622-2.0/+merge/181133
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpa
The proposal to merge lp:~raoul-snyman/openlp/bug-1088800-2.0 into
lp:openlp/2.0 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1088800-2.0/+merge/181134
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-108
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1088800-2.0/+merge/181134
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpa
I reckon it should just be empty. We just need to then make sure the
person fills it in.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1201691
Title:
Cannot create new formatting tag if one an exist
Review: Approve
Tested and UI works fine
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1194622-2.0/+merge/181133
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : op
** Changed in: openlp/2.0
Status: Confirmed => In Progress
** Changed in: openlp/2.0
Assignee: (unassigned) => Raoul Snyman (raoul-snyman)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/108
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1088800-2.0/+merge/181134
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpa
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-1088800-2.0 into
lp:openlp/2.0.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1088800 in OpenLP: "Macro enabled presentations are not shown in OpenLP"
https://bugs.launchpad.net/openlp/+bug/1088800
For more det
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-1194622-2.0 into
lp:openlp/2.0.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1194622 in OpenLP: "[support-system] Traceback when importing bible with
disabled bible plugin in FTW"
https://bugs.launchpad.net/op
** Branch linked: lp:~raoul-snyman/openlp/bug-1088800-2.0
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1088800
Title:
Macro enabled presentations are not shown in OpenLP
Status in OpenLP - Worship
** Changed in: openlp/2.0
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1211913
Title:
Issues importing Sunday Plus FIles
Status in OpenLP - Worship Pres
Leaving open as songs will be fixed as well
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1194622
Title:
[support-system] Traceback when importing bible with disabled bible
plugin in FTW
Status i
The proposal to merge lp:~raoul-snyman/openlp/bug-1194622-2.0 into
lp:openlp/2.0 has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1194622-2.0/+merge/180948
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-11946
The proposal to merge lp:~phill-ridout/openlp/1211913_2.0 into lp:openlp/2.0
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1211913_2.0/+merge/180746
--
https://code.launchpad.net/~phill-ridout/openlp/1211913_2.0/+merge/18
That's a good idea. I'll do that this evening.
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1194622-2.0/+merge/180948
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
The proposal to merge lp:~phill-ridout/openlp/1211913_2.0 into lp:openlp/2.0
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/1211913_2.0/+merge/180746
--
https://code.launchpad.net/~phill-ridout/openlp/1211913_2.0/+me
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1211913_2.0/+merge/180746
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
Review: Approve
Looks fine. Should we do the same with songs ?
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-1194622-2.0/+merge/180948
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp
Review: Approve
--
https://code.launchpad.net/~phill-ridout/openlp/1211913_2.0/+merge/180746
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.ne
** Changed in: openlp/2.0
Assignee: (unassigned) => Raoul Snyman (raoul-snyman)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1194622
Title:
[support-system] Traceback when importing bible with
59 matches
Mail list logo