Re: [Openlp-core] [Merge] lp:~felipe-q/openlp/refactoring_fixes into lp:openlp

2014-01-09 Thread Raoul Snyman
Hi Felipe, - Settings.__default_settings__[key] fails for non-existant keys... changed to .get(key,'') This is actually intentional. I also thought this was incorrect until I realised that I was doing things the wrong way. Every plugin has a set of default settings, and all you need to do is a

Re: [Openlp-core] [Merge] lp:~felipe-q/openlp/refactoring_fixes into lp:openlp

2014-01-09 Thread Felipe Polo-Wood
I give up, man. I can't work like this. You are allowed to merge code that won't even start without errors in Windows, I fixed it so it at least starts, and now I have to create tests for fixing your code? I will be uploading the code that enables WebSocket according to RFC6455 and that would

Re: [Openlp-core] [Merge] lp:~felipe-q/openlp/refactoring_fixes into lp:openlp

2014-01-09 Thread Tim Bentley
Review: Needs Fixing Not sure about the settings changes the rest look OK. You are missing tests though -- https://code.launchpad.net/~felipe-q/openlp/refactoring_fixes/+merge/200892 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Bug 1247661] Re: Cannot restore OpenLP after minimising on OSX

2014-01-09 Thread matysek
I also found out that when you minimize openlp main window then the menu bar changes and only item "Python" is there. Shouldn't be the menubar the same even when the presentation window is active? ** Attachment added: "Openlp menu bar with minimized main window" https://bugs.launchpad.net/open